8000 Adding tests for IntervalArray.unique() for DateTimeArrays with time zones by Dr-Irv · Pull Request #46153 · pandas-dev/pandas · GitHub
[go: up one dir, main page]

Skip to content

Adding tests for IntervalArray.unique() for DateTimeArrays with time zones #46153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Feb 26, 2022

Conversation

Dr-Irv
Copy link
Contributor
@Dr-Irv Dr-Irv commented Feb 25, 2022

Ref suggestion here; #46128

@Dr-Irv Dr-Irv requested a review from jbrockmendel February 25, 2022 20:35
@Dr-Irv Dr-Irv added Interval Interval data type Testing pandas testing functions or related to the test suite labels Feb 25, 2022
# GH 46128
dti1 = date_range("2016-01-01", periods=3)
ii1 = IntervalIndex.from_breaks(dti1)
ser1 = pd.Series(ii1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you either put this in the series tests or test the array method directly. ideally do a tm.assert_foo_equal below, should be easy bc .unique matches self in these cases

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, moved to series tests in next commit.

@jreback jreback added this to the 1.5 milestone Feb 26, 2022
@jreback jreback merged commit c2188de into pandas-dev:main Feb 26, 2022
@jreback
Copy link
Contributor
jreback commented Feb 26, 2022

thanks @Dr-Irv

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@Dr-Irv Dr-Irv deleted the testintervalunique branch February 13, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Interval Interval data type Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0