8000 ENH: add NDArrayBackedExtensionArray to public API by tswast · Pull Request #45544 · pandas-dev/pandas · GitHub
[go: up one dir, main page]

Skip to content

ENH: add NDArrayBackedExtensionArray to public API #45544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 31 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
bfd31f0
Merge branch 'main' into python-db-dtypes-pandas-issue28
tswast Apr 7, 2022
396da54
Merge branch 'main' into python-db-dtypes-pandas-issue28
jreback Apr 10, 2022
27cf80e
Merge branch 'main' into python-db-dtypes-pandas-issue28
tswast May 20, 2022
c716826
Merge branch 'main' into python-db-dtypes-pandas-issue28
tswast Jun 7, 2022
f4df0e9
Merge branch 'main' into python-db-dtypes-pandas-issue28
tswast Aug 25, 2022
8876b9a
clarify _validate_searchsorted_value and 2d backing array
tswast Aug 26, 2022
1bdd1cd
Merge branch 'main' into python-db-dtypes-pandas-issue28
tswast Aug 29, 2022
4b0a948
Merge remote-tracking branch 'upstream/main' into python-db-dtypes-pa…
tswast Nov 22, 2022
5920778
Merge branch 'python-db-dtypes-pandas-issue28' of github.com:tswast/p…
tswast Nov 22, 2022
38018e6
DOC: make insert docstring have single line summary
tswast Nov 23, 2022
9277cf5
Merge remote-tracking branch 'upstream/main' into python-db-dtypes-pa…
tswast Nov 23, 2022
0b86bd5
Merge branch 'main' into python-db-dtypes-pandas-issue28
tswast Nov 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clarify _validate_searchsorted_value and 2d backing array
  • Loading branch information
tswast committed Aug 26, 2022
commit 8876b9afb0a44a47445d753b2b06f387e026b9d1
4 changes: 3 additions & 1 deletion doc/source/development/extending.rst
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,8 @@ Implement the following:

``_validate_searchsorted_value``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 2.0 i think this is going away and we'll re-use _validate_setitem_value for this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified that most implementations will be identical to _validate_setitem_value.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_validate_searchsorted_value is gone now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove _validate_searchsorted_value here

Convert a value for use in searching for a value in the backing NumPy array.
Note: in most cases, the implementation can be identical to that of
``_validate_setitem_value``.

.. code-block:: python

Expand Down Expand Up @@ -196,7 +198,7 @@ Implement the following:


To support 2D arrays, use the ``_from_backing_data`` helper function when a
method is called on multi-dimensional data.
method is called on multi-dimensional data of the same dtype as ``_ndarray``.

.. code-block:: python

Expand Down
0