-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
WARN: Add FutureWarning to DataFrame.to_html
#44451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
2fa2246
add warning
attack68 89225de
add test
attack68 1119a27
fix doc warnings
attack68 93d9288
fix test for warning
attack68 2e653fe
filterwarnings
attack68 8e10574
skip doctest
attack68 e4fa4ef
test warnings
attack68 e20c5d9
test warnings
attack68 e6fc67e
Merge remote-tracking branch 'upstream/master' into depr_to_html_to_l…
attack68 310bdc2
warn and expand tests
attack68 3524116
see also
attack68 43acc91
Merge remote-tracking branch 'upstream/master' into depr_to_html_afte…
attack68 f41a438
allow warnings in io.rst
attack68 ad8cf24
allow warnings in scale.rst
attack68 0d5b4b3
aedit io.rst
attack68 bd5e91c
aedit io.rst
attack68 7e3c3df
test warnings
attack68 7de29d1
remove okwarning
attack68 f2a944a
pytest filters
attack68 5f4d55c
Merge remote-tracking branch 'upstream/master' into depr_to_html_afte…
attack68 6a4523e
whats new
attack68 9e66a72
add explicit test
attack68 505953d
Merge remote-tracking branch 'upstream/master' into depr_to_html_afte…
attack68 d859877
more specific warnings
attack68 02d913c
more specific warnings
attack68 7d5ab6c
more specific warnings (filters removed)
attack68 a9e4ac4
more specific warnings (filters removed)
attack68 ee97624
Merge remote-tracking branch 'upstream/master' into depr_to_html_afte…
attack68 10a34cb
Merge remote-tracking branch 'upstream/master' into depr_to_html_afte…
attack68 272670a
doc string addition
attack68 3af20b6
Merge remote-tracking branch 'upstream/master' into depr_to_html_afte…
attack68 6962393
Merge remote-tracking branch 'upstream/master' into depr_to_html_afte…
attack68 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
warn and expand tests
- Loading branch information
commit 310bdc2fa099599bbb57e4291847a53a02cbd06a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we intend to keep
DataFrame.to_html
but only change the signature, then I think such a general deprecation warning is overly broad (many people doing justdf.to_html()
will also see the warning while they actually don't need to change anything?)Would it be an alternative to specifically check for keywords we know will change in the signature, and only warn for those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an example is #41648 on which kwargs might be removed or changed.
there are quite a few, and to be honest not sure at this point we could commit to knowing with certainty how they will change.
i agree with you that it might be overly broad, the warning does not show in jupyter notebook when rendering a df by default, only when the method
to_html
is specifically calledThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something else i considered was just implementing a
DataFrame.to_html2
method temporarily, and then issuing the warning and progressively merging through version cycles?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jorisvandenbossche I have gone through and targeted the kwargs that will change and and only warn when they are input as non-default values. Please review