-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
REF: DataFrame.to_latex
directs to Styler.to_latex
#41648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
121 commits
Select commit
Hold shift + click to select a range
c586522
add future warning
attack68 74d7ff2
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 ece5987
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 4a9b076
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 5a97aad
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 edd91ec
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 8821026
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 e03e014
build format_index mechanics
attack68 bb9b5b2
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 fb86279
test index formatter display_value, and clearing
attack68 846e5a2
prelim doc string
attack68 9e995e1
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 7e9400a
format_index docs
attack68 9c63ab8
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 87a6c88
refactor for perf
attack68 9c969ad
add test
attack68 26f3906
add tests: escape
attack68 ec40418
add tests: escape na_rep
attack68 0de5397
add tests: raises
attack68 6fe8285
test decimal and thousands
attack68 6b61e31
test precision
attack68 6eaa933
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 666e460
whats new
attack68 49bb731
level tests
attack68 044cd05
user guide
attack68 8fc497d
typing fix
attack68 8fb9519
user guide refactor
attack68 d039105
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 df7548c
input to axis
attack68 6523f48
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 5091d49
reformating
attack68 c686adb
add and document arg changes
attack68 0df2aaf
add and document arg changes
attack68 6accdfa
test changes
attack68 3448a9a
test changes
attack68 ef235e5
refactor to account for precision=0
attack68 d06128f
refactor to account for precision=0
attack68 e6b2eef
edits tests to pass
attack68 5fb997d
edits tests to pass
attack68 0d91aff
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 e36f198
fix tests
attack68 4fd6e68
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 5be0006
Merge branch 'styler_format_index' into depr_df_to_latex
attack68 c966942
fix tests
attack68 f6ceadb
fix tests
attack68 949e39d
fix tests
attack68 a721d6e
fix tests
attack68 9ec466b
fix tests
attack68 5652a58
fix tests
attack68 e7338ab
fix tests
attack68 1842e18
fix tests
attack68 120a121
fix tests
attack68 27a928e
fix tests
attack68 d7779b6
multirow naive implementation
attack68 11ac603
multirow naive implementation
attack68 7920037
multirow naive implementation
attack68 f74c1a5
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 eee3cd1
remove validation capture
attack68 0c624a1
Merge branch 'latex_multicol_naive' into depr_df_to_latex
attack68 5c170fd
Merge branch 'latex_multirow_naive' into depr_df_to_latex
attack68 0c55981
fix tests
attack68 241a896
fix tests
attack68 ad844a9
fix tests
attack68 8cba047
fix tests
attack68 7f314a0
fix tests
attack68 49c929d
fix tests
attack68 7912127
fix tests
attack68 6ea94bf
fix tests
attack68 c4bf504
fix tests
attack68 1b33ec5
fix tests
attack68 f7da49e
fix tests
attack68 2a1b9c2
remove test: caption validation
attack68 30832ae
siunitx changes: render {} only when needed.
attack68 13dd5c8
Merge branch 'styler_siunitx_headers_parse' into depr_df_to_latex
attack68 e07f6d0
revert braces in tests
attack68 c7396bb
revert braces in tests
attack68 a191b3d
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 121062f
Merge remote-tracking branch 'upstream/master' into latex_multirow_naive
attack68 8ea7b0c
Merge remote-tracking branch 'upstream/master' into latex_multicol_naive
attack68 b87ef09
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 c161df3
fix tests
attack68 b1d8a27
amend tests for siunitx
attack68 7e9cc49
Merge branch 'latex_multirow_naive' into depr_df_to_latex
attack68 2998507
Merge branch 'latex_multicol_naive' into depr_df_to_latex
attack68 8ac31d6
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 08223d7
fix tests
attack68 1d038c9
warn deprecated args
attack68 3ee4012
add note to docstring
attack68 8b40beb
mypy fixes
attack68 02f4b16
arg changes
attack68 9a7a8e4
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 ecd01dd
fix recent merged tests
attack68 63e18e2
fix recent merged tests
attack68 a21590b
refactor to_latex
attack68 13906fe
refactor to_latex encoding
attack68 b7431be
reorder-args
attack68 9cd0033
fix escape
attack68 910bbae
fix docstring tests
attack68 0b81918
fix docstring tests
attack68 54b98b7
add jinja2 hard dep
attack68 0f0eb84
edit docs
attack68 4c4ba6d
edit docs
attack68 6ff376d
Merge branch 'jinja2_hard_dependency' into depr_df_to_latex
attack68 fabddd0
fix tests by avoiding numpy ambiguous
attack68 bfb74c2
mypy fix
attack68 37b7112
fix repr tests
attack68 1bfbe1b
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 d81fd18
fix repr tests
attack68 9389426
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 1a32d17
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 afa6da3
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 eca71a9
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 b112ac5
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 7e6bf97
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 06ce6bf
add to style.rst
attack68 b8c225a
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 9562b3d
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 4aa58e8
Merge remote-tracking branch 'upstream/master' into styler_format_index
attack68 a35f4e6
Merge branch 'styler_format_index' into depr_df_to_latex
attack68 249022a
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 ed399e7
Merge remote-tracking branch 'upstream/master' into depr_df_to_latex
attack68 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix tests
- Loading branch information
commit 6ea94bfa1600369b0a1d220976941dcb078f2ce4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything below this line contains quite complex logic.
I suppose that extracting a whole new class, like
StylerLatexAdapter
or something like this, may be reasonable here.It will then be possible to encapsulate kwargs deprecation, handling headers, index, etc there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a gap in
Styler
currently sinceformat_index
is so new, that aStyler
class can be instantiated with formatting variable for data objects, but not for index objects. Of course it opens up a query how best to do this since there are quite a lot of formatting args and if applied to data values and each index separately it introduces a potential host of new args.With regards to the general complexity, yes I agree the logic has been to squeeze one method into the other and an adapter might be useful. Can we wait on feedback from others too?