take indexing out of loops

pandas-dev · jreback · May 6, 2021 · May 2, 2021 · May 2, 2021 · May 2, 2021
commit c3b7af8214cae0681a4bd37062346ac3a29c9b6a
diff --git a/pandas/io/formats/style_render.py b/pandas/io/formats/style_render.py
@@ -479,42 +479,55 @@ def format(
         subset = non_reducing_slice(subset)
         data = self.data.loc[subset]
 
-        columns = data.columns
         if not isinstance(formatter, dict):
-            formatter = {col: formatter for col in columns}
-
-        if self.index.is_unique and self.columns.is_unique:
-            for col in columns:
-                format_func = _maybe_wrap_formatter(
-                    formatter.get(col),
-                    na_rep=na_rep,
-                    precision=precision,
-                    decimal=decimal,
-                    thousands=thousands,
-                    escape=escape,
-                )
-
-                j = self.columns.get_loc(col)  # single value
-                for row, value in data[[col]].itertuples():
-                    i = self.index.get_loc(row)  # single value
-                    self._display_funcs[(i, j)] = format_func
-        else:  # will get multiple index value locs to loop over at performance cost
-            for col in columns:
-                format_func = _maybe_wrap_formatter(
-                    formatter.get(col),
-                    na_rep=na_rep,
-                    precision=precision,
-                    decimal=decimal,
-                    thousands=thousands,
-                    escape=escape,
-                )
-
-                j_ = self.columns.get_indexer_for([col])  # handle non-unique columns
-                for row in data[[col]].itertuples():
-                    i_ = self.index.get_indexer_for([row[0]])  # handle non-unique index
-                    for i in i_:
-                        for j in j_:
-                            self._display_funcs[(i, j)] = format_func
+            formatter = {col: formatter for col in data.columns}
+
+        cis = self.columns.get_indexer_for(data.columns)
+        ris = self.index.get_indexer_for(data.index)
+        for ci in cis:
+            format_func = _maybe_wrap_formatter(
+                formatter.get(self.columns[ci]),
+                na_rep=na_rep,
+                precision=precision,
+                decimal=decimal,
+                thousands=thousands,
+                escape=escape,
+            )
+            for ri in ris:
+                self._display_funcs[(ri, ci)] = format_func
+
+        # if self.index.is_unique and self.columns.is_unique:
+        #     for col in columns:
+        #         format_func = _maybe_wrap_formatter(
+        #             formatter.get(col),
+        #             na_rep=na_rep,
+        #             precision=precision,
+        #             decimal=decimal,
+        #             thousands=thousands,
+        #             escape=escape,
+        #         )
+        #
+        #         j = self.columns.get_loc(col)  # single value
+        #         for row, value in data[[col]].itertuples():
+        #             i = self.index.get_loc(row)  # single value
+        #             self._display_funcs[(i, j)] = format_func
+        # else:  # will get multiple index value locs to loop over at performance cost
+        #     for col in columns:
+        #         format_func = _maybe_wrap_formatter(
+        #             formatter.get(col),
+        #             na_rep=na_rep,
+        #             precision=precision,
+        #             decimal=decimal,
+        #             thousands=thousands,
+        #             escape=escape,
+        #         )
+        #
+        #         j_ = self.columns.get_indexer_for([col])  # handle non-unique columns
+        #         for row in data[[col]].itertuples():
+        #           i_ = self.index.get_indexer_for([row[0]])  # handle non-unique index
+        #             for i in i_:
+        #                 for j in j_:
+        #                     self._display_funcs[(i, j)] = format_func
 
         return self