10BC0 BUG: incorrect rounding in groupby.cummin near int64 implementation bounds by jbrockmendel · Pull Request #40767 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: incorrect rounding in groupby.cummin near int64 implementation bounds #40767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jreback merged 10 commits into from
Apr 14, 2021
Merged

BUG: incorrect rounding in groupby.cummin near int64 implementation bounds #40767

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7936a9c
BUG: groupby.cummin losing precision on large integers
jbrockmendel Apr 2, 2021
234419e
simplify check
jbrockmendel Apr 2, 2021
2e87770
Merge branch 'master' into ref-gbop
jbrockmendel Apr 4, 2021
850f985
Merge branch 'master' into ref-gbop
jbrockmendel Apr 5, 2021
b8f5a28
Handle min/max
jbrockmendel Apr 6, 2021
5db0964
Merge branch 'master' into ref-gbop
jbrockmendel Apr 12, 2021
e5cf34d
comment+GH ref
jbrockmendel Apr 12, 2021
3f06416
Merge branch 'master' into ref-gbop
jbrockmendel Apr 13, 2021
eeba093
whatsnew
jbrockmendel Apr 13, 2021
c2e75be
Merge branch 'master' into ref-gbop
jbrockmendel Apr 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
comment+GH ref
  • Loading branch information
@jbrockmendel
jbrockmendel committed Apr 12, 2021
commit e5cf34d2201f8125354726e16818639d80a3c749
4 changes: 3 additions & 1 deletion pandas/core/groupby/ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,9 @@ def _cython_operation(
func(result, values, comp_ids, ngroups, is_datetimelike, **kwargs)

if kind == "aggregate":
# i.e. counts is defined
# i.e. counts is defined. Locations where count<min_count
# need to have the result set to np.nan, which may require casting,
# see GH#40767
if is_integer_dtype(result.dtype) and not is_datetimelike:
cutoff = max(1, min_count)
empty_groups = counts < cutoff
Expand Down
0