8000 TYP: fix ignores by jbrockmendel · Pull Request #40452 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

TYP: fix ignores #40452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 17, 2021
Merged

TYP: fix ignores #40452

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
6759676
TYP: dtypes.cast
jbrockmendel Mar 14, 2021
2f1ae91
TYP: dtypes.cast
jbrockmendel Mar 14, 2021
1ee41ae
TYP: dtypes.cast
jbrockmendel Mar 14, 2021
e9b59d1
TYP: missing
jbrockmendel Mar 14, 2021
6277b44
TYP: ignores in dtpyes.missing
jbrockmendel Mar 14, 2021
453d289
TYP: ignores in internals.construction
jbrockmendel Mar 15, 2021
fa6bcfd
TYP: internals.construction
jbrockmendel Mar 15, 2021
2e5ea07
TYP: internals.construction
jbrockmendel Mar 15, 2021
28c4733
TYP: fix ignores
jbrockmendel Mar 15, 2021
26a4fb0
TYP: frame
jbrockmendel Mar 15, 2021
b17b8c4
TYP: ignores
jbrockmendel Mar 15, 2021
411e3e3
TYP: fix ignores
jbrockmendel Mar 15, 2021
5a29047
more specific docstring
jbrockmendel Mar 15, 2021
801ea35
Merge branch 'master' into typ-core-3
jbrockmendel Mar 16, 2021
4e8cb5f
update docstring
jbrockmendel Mar 16, 2021
8adca0c
Merge branch 'master' into typ-core-3
jbrockmendel Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TYP: internals.construction
  • Loading branch information
@jbrockmendel
jbrockmendel committed Mar 15, 2021
commit fa6bcfd286ee75dc97da178da7c7092f3c2f5ebe
23 changes: 7 additions & 16 deletions pandas/core/internals/construction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,27 +693,18 @@ def to_arrays(
return arrays, columns

if isinstance(data[0], (list, tuple)):
content = _list_to_arrays(data)
arr = _list_to_arrays(data)
elif isinstance(data[0], abc.Mapping):
content, columns = _list_of_dict_to_arrays(data, columns)
arr, columns = _list_of_dict_to_arrays(data, columns)
elif isinstance(data[0], ABCSeries):
content, columns = _list_of_series_to_arrays(data, columns)
arr, columns = _list_of_series_to_arrays(data, columns)
else:
# last ditch effort
data = [tuple(x) for x in data]
content = _list_to_arrays(data)
arr = _list_to_arrays(data)

# error: Incompatible types in assignment (expression has type "List[ndarray]",
# variable has type "List[Union[Union[str, int, float, bool], Union[Any, Any, Any,
# Any]]]")
content, columns = _finalize_columns_and_data( # type: ignore[assignment]
content, columns, dtype
)
# error: Incompatible return value type (got "Tuple[ndarray, Index]", expected
# "Tuple[List[ExtensionArray], Index]")
# error: Incompatible return value type (got "Tuple[ndarray, Index]", expected
# "Tuple[List[ndarray], Index]")
return content, columns # type: ignore[return-value]
content, columns = _finalize_columns_and_data(arr, columns, dtype)
return content, columns


def _list_to_arrays(data: List[Union[Tuple, List]]) -> np.ndarray:
Expand Down Expand Up @@ -804,7 +795,7 @@ def _finalize_columns_and_data(
content: np.ndarray, # ndim == 2
columns: Optional[Index],
dtype: Optional[DtypeObj],
) -> Tuple[List[np.ndarray], Index]:
) -> Tuple[List[ArrayLike], Index]:
"""
Ensure we have valid columns, cast object dtypes if possible.
"""
Expand Down
0