8000 DEP: bump min version of openpyxl to 3.0.0 #39603 by fangchenli · Pull Request #39702 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

DEP: bump min version of openpyxl to 3.0.0 #39603 #39702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 15, 2021
Merged

DEP: bump min version of openpyxl to 3.0.0 #39603 #39702

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
69bad56
DEP: bump min version of openpyxl to 3.0.0 #39603
fangchenli Feb 9, 2021
035b454
fix import
fangchenli Feb 9, 2021
97c7c25
Merge remote-tracking branch 'upstream/master' into bump-openpyxl
fangchenli Feb 11, 2021
7ef8ab5
remove version compat in openpyxl test
fangchenli Feb 11, 2021
36407e1
Merge remote-tracking branch 'upstream/master' into bump-openpyxl
fangchenli Feb 11, 2021
9d1d82f
add comments back
fangchenli Feb 13, 2021
eaf0555
Merge remote-tracking branch 'upstream/master' into bump-openpyxl
fangchenli Feb 13, 2021
3190324
Merge branch 'master' into bump-openpyxl
fangchenli Feb 15, 2021
35c8b2e
Merge remote-tracking branch 'upstream/master' into bump-openpyxl
fangchenli Feb 15, 2021
006e4ae
fix typo
fangchenli Feb 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix import
  • Loading branch information
@fangchenli
fangchenli committed Feb 9, 2021
commit 035b454d6957b6973c2f2b4ac4b6e176afc889c7
4 changes: 0 additions & 4 deletions pandas/io/excel/_openpyxl.py
View file 8000
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,10 +530,6 @@ def _convert_cell(self, cell, convert_float: bool) -> Scalar:
return cell.value

def get_sheet_data(self, sheet, convert_float: bool) -> List[List[Scalar]]:
# GH 39001
# Reading of excel file depends on dimension data being correct but
# writers sometimes omit or get it wrong
import openpyxl

# There is no good way of determining if a sheet is read-only
# https://foss.heptapod.net/openpyxl/openpyxl/-/issues/1605
Expand Down
0