8000 REG: read_excel with engine specified raises on non-path/non-buffer by rhshadrach · Pull Request #39586 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

REG: read_excel with engine specified raises on non-path/non-buffer #39586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 7, 2021
Merged

REG: read_excel with engine specified raises on non-path/non-buffer #39586

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b887183
REG: read_excel with engine specified raises on non-path/non-buffer
rhshadrach Feb 3, 2021
2291988
Merge branch 'master' of https://github.com/pandas-dev/pandas into op…
rhshadrach Feb 3, 2021
601ad87
Restore special-casing for xlrd.Book even when engine is None
rhshadrach Feb 3, 2021
d835dff
GH # in test
rhshadrach Feb 3, 2021
e6684e9
Added wb.close() to test
rhshadrach Feb 4, 2021
1f16602
Merge branch 'master' of https://github.com/pandas-dev/pandas into op…
rhshadrach Feb 5, 2021
ba2bc75
Added logic/tests for determining if a sheet is read-only
rhshadrach Feb 5, 2021
1381ecc
Added comment
rhshadrach Feb 5, 2021
a3db3eb
Combine and reorg tests
rhshadrach Feb 5, 2021
33acfaa
Only mark as xfail for read-only cases
rhshadrach Feb 6, 2021
224d2a1
fixup
rhshadrach Feb 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only mark as xfail for read-only cases
  • Loading branch information
@rhshadrach
rhshadrach committed Feb 6, 2021
commit 33acfaa19077248e04a0ffa0be5ab82aa3b5ee36
12 changes: 7 additions & 5 deletions pandas/tests/io/excel/test_openpyxl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,16 @@ def test_read_workbook(datapath, ext, read_only):
)
# When read_only is None, use read_excel instead of a workbook
@pytest.mark.parametrize("read_only", [True, False, None])
@pytest.mark.xfail(
LooseVersion(get_version(openpyxl)) < "3.0.0",
reason="openpyxl read-only sheet is incorrect when dimension data is wrong",
)
def test_read_with_bad_dimension(
datapath, ext, header, expected_data, filename, read_only
datapath, ext, header, expected_data, filename, read_only, request
):
# GH 38956, 39001 - no/incorrect dimension information
version = LooseVersion(get_version(openpyxl))
if (read_only or read_only is None) and version < "3.0.0":
msg = "openpyxl read-only sheet is incorrect when dimension data is wrong"
request.node.add_marker(
pytest.mark.xfail(LooseVersion(get_version(openpyxl)) < "3.0.0", reason=msg)
)
path = datapath("io", "data", "excel", f"{filename}{ext}")
if read_only is None:
result = pd.read_excel(path, header=header)
Expand Down
0