10000 BUG: DataFrame.append with timedelta64 by jbrockmendel · Pull Request #39574 · pandas-dev/pandas · GitHub
[go: up one dir, main page]

Skip to content

BUG: DataFrame.append with timedelta64 #39574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 12, 2021
Merged
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pandas/core/internals/concat.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,7 @@ def dtype(self):
def is_valid_na_for(self, dtype: DtypeObj) -> bool:
"""
Check that we are all-NA of a type/dtype that is compatible with this dtype.
Augments `self.is_na` with an additional check of the type of NA values.
"""
if not self.is_na:
return False
Expand All @@ -243,7 +244,7 @@ def is_valid_na_for(self, dtype: DtypeObj) -> bool:
if self.dtype.kind == dtype.kind == "M" and not is_dtype_equal(
self.dtype, dtype
):
# fill_values match but we should not case self.block.values to dtype
# fill_values match but we should not cast self.block.values to dtype
return False

na_value = self.block.fill_value
Expand Down
0