BUG/API: remove infer_types from replace and fix compiled regex bug #3909
Conversation
|
@jreback merge-able? i can remove |
|
u know what let me add some tests for the things i added to |
|
did Travis check this? |
|
it did but i just pushed another commit so rerunning :| |
|
(passed the first time) |
|
ok now it's ready |
|
ok just recall if I changed something really low level sometimes things break |
|
oh. what did u change that is low-level? |
|
no was a while ago |
|
ah len is there for |
|
and i will write a test so that someone doesn't take it out in the future |
|
although a test still passes because of my addition of |
|
oh i also need 2 change the replace docs i think... |
|
nope nothing about |
|
ok build is passing. |
|
@jreback merge-able round 2? |
|
looks good |
closes #3907.