8000 API: honor copy=True when passing dict to DataFrame by jbrockmendel · Pull Request #38939 · pandas-dev/pandas · GitHub
[go: up one dir, main page]

Skip to content

API: honor copy=True when passing dict to DataFrame #38939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 69 commits into from
Mar 31, 2021
Merged
Changes from 1 commit
Commits
Show all changes
69 commits
Select commit Hold shift + click to select a range
cbc97f0
ENH: allow non-consolidation in constructors
jbrockmendel Oct 5, 2020
a135d96
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
jbrockmendel Oct 5, 2020
5c94129
mypy fixup
jbrockmendel Oct 5, 2020
d653c54
ENH: allow non-consolidation in constructors
jbrockmendel Oct 5, 2020
e71e319
Merge branch 'myway-init-no-consolidate' of github.com:jbrockmendel/p…
jbrockmendel Jan 3, 2021
cafa718
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
jbrockmendel Jan 3, 2021
c706ad6
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
jbrockmendel Jan 3, 2021
3f9195e
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
jbrockmendel Jan 4, 2021
1cba671
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
jbrockmendel Jan 4, 2021
396daba
BUG: respect copy=False in constructing DataFrame from dict
jbrockmendel Jan 4, 2021
11ae1c9
whatsnew
jbrockmendel Jan 4, 2021
b505267
clean test
jbrockmendel Jan 4, 2021
a1e9b68
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
jbrockmendel Jan 4, 2021
b70d997
fixed xfail
jbrockmendel Jan 4, 2021
09213e0
update whatsnew
jbrockmendel Jan 4, 2021
e895de0
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
jbrockmendel Jan 4, 2021
31bda58
de-kludge
jbrockmendel Jan 4, 2021
37a2c0c
remove no-longer-used msg
jbrockmendel Jan 4, 2021
b93d7d5
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
jbrockmendel Jan 10, 2021
aa667a6
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
jbrockmendel Jan 12, 2021
185cd99
fix broken test
jbrockmendel Jan 12, 2021
701356f
Consolidate in tm, update whatsnew
jbrockmendel Jan 20, 2021
948ac67
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
jbrockmendel Jan 21, 2021
46f2fcf
always copy when data is None
jbrockmendel Jan 21, 2021
0bbfec0
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Jan 23, 2021
590c820
update exception message
jbrockmendel Jan 23, 2021
17a693c
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
jbrockmendel Jan 27, 2021
fb8f32d
update exception message
jbrockmendel Jan 27, 2021
7835184
typo fixup
jbrockmendel Jan 28, 2021
2136289
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Feb 2, 2021
187499c
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Feb 2, 2021
6f30beb
Merge branch 'master' of https://github.com/pandas-dev/pandas into my…
jbrockmendel Feb 4, 2021
e80d57c
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Feb 11, 2021
b0a6abd
CI: fix broken asv
jbrockmendel Feb 11, 2021
bf942ae
revert
jbrockmendel Feb 11, 2021
95e30a5
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Feb 11, 2021
510f697
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Feb 13, 2021
48e359e
Default to copy=True for dict data
jbrockmendel Feb 13, 2021
048e826
troubleshoot docbuild
jbrockmendel Feb 16, 2021
6a9c9f0
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Feb 17, 2021
a17c728
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Feb 18, 2021
5b3d419
update whatsnew
jbrockmendel Feb 18, 2021
f961378
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Feb 18, 2021
fcee44b
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Feb 27, 2021
0c60ae8
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Feb 27, 2021
1468e59
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Feb 27, 2021
b6d8b70
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Mar 3, 2021
8b66b11
skip for ArrayManager
jbrockmendel Mar 3, 2021
54cacfc
Update doc/source/whatsnew/v1.3.0.rst
jbrockmendel Mar 6, 2021
5ea7a75
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Mar 6, 2021
e11ea68
requested edits
jbrockmendel Mar 6, 2021
65d01c7
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Mar 8, 2021
41c4e7a
test test_df_mod_zero_df with and without copy
jbrockmendel Mar 8, 2021
7260a72
collect copy-adjusting code in one place
jbrockmendel Mar 9, 2021
52344bb
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Mar 14, 2021
3ddc3d3
update docstring
jbrockmendel Mar 14, 2021
e6bae0f
whatsnew, comment
jbrockmendel Mar 14, 2021
7cab084
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Mar 15, 2021
e8e3d84
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Mar 15, 2021
5c44953
mypy fixup
jbrockmendel Mar 15, 2021
8000
e32f630
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Mar 16, 2021
abd890a
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Mar 16, 2021
1b7f7ca
Update pandas/core/frame.py
jbrockmendel Mar 16, 2021
b326b5f
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Mar 22, 2021
b7aed5d
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Mar 26, 2021
4d20fe7
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Mar 30, 2021
ad5485a
add versionchanged
jbrockmendel Mar 30, 2021
6bed6ac
Merge branch 'master' into myway-init-no-consolidate
jbrockmendel Mar 30, 2021
98b6dff
update bc .values has changed to DTA/TDA
jbrockmendel Mar 30, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
8000 Next Next commit
de-kludge
  • Loading branch information
jbrockmendel committed Jan 4, 2021
commit 31bda587d8ab6465ca5d439bc4c2ed0f5037776c
16 changes: 5 additions & 11 deletions pandas/core/internals/managers.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

import numpy as np

from pandas._libs import NaT, internals as libinternals, lib
from pandas._libs import internals as libinternals, lib
from pandas._typing import ArrayLike, DtypeObj, Label, Shape
from pandas.errors import PerformanceWarning
from pandas.util._validators import validate_bool_kwarg
Expand All @@ -40,7 +40,7 @@
import pandas.core.algorithms as algos
from pandas.core.arrays.sparse import SparseDtype
from pandas.core.base import PandasObject
from pandas.core.construction import extract_array
from pandas.core.construction import ensure_wrapped_if_datetimelike, extract_array
from pandas.core.indexers import maybe_convert_indices
from pandas.core.indexes.api import Index, ensure_index
from pandas.core.internals.blocks import (
Expand Down Expand Up @@ -952,19 +952,13 @@ def fast_xs(self, loc: int) -> ArrayLike:
else:
result = np.empty(n, dtype=dtype)

result = ensure_wrapped_if_datetimelike(result)

for blk in self.blocks:
# Such assignment may incorrectly coerce NaT to None
# result[blk.mgr_locs] = blk._slice((slice(None), loc))
for i, rl in enumerate(blk.mgr_locs):
out = blk.iget((i, loc))
if is_dtype_equal(blk.dtype, dtype) and dtype == "m8[ns]":
# FIXME: kludge for NaT -> tdnat
# TODO: need a test like test_sum_nanops_timedelta
# where initial DataFrame is not consolidated
if out is NaT:
result[rl] = np.timedelta64("NaT", "ns")
continue
result[rl] = out
result[rl] = blk.iget((i, loc))

if isinstance(dtype, ExtensionDtype):
result = dtype.construct_array_type()._from_sequence(result, dtype=dtype)
Expand Down
0