10000 BUG: read_csv usecols and names parameters inconsistent between c and python by phofl · Pull Request #38445 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: read_csv usecols and names parameters inconsistent between c and python #38445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 13, 2020
Merged

BUG: read_csv usecols and names parameters inconsistent between c and python #38445

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0557b52
Try fixing inconsistency
phofl Dec 12, 2020
f98f79a
Fix inconsistency
phofl Dec 13, 2020
ddc1e1b
Remove function input
phofl Dec 13, 2020
db09ae8
Merge branch 'master' of https://github.com/pandas-dev/pandas into 16469
phofl Dec 13, 2020
ecfff70
Add whatsnew
phofl Dec 13, 2020
86f0f97
Remove unncesscary function call
phofl Dec 13, 2020
a8bb14a
Simplify code
phofl Dec 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove function input
  • Loading branch information
@phofl
phofl committed Dec 13, 2020
commit ddc1e1ba3feab9a10dba402853e45db240bbd4b6
2 changes: 1 addition & 1 deletion pandas/tests/io/parser/test_usecols.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ def test_raises_on_usecols_names_mismatch(all_parsers, usecols, kwargs, expected


@pytest.mark.parametrize("usecols", [["A", "C"], [0, 2]])
def test_usecols_subset_names_mismatch_orig_columns(all_parsers, usecols, request):
def test_usecols_subset_names_mismatch_orig_columns(all_parsers, usecols):
data = "a,b,c,d\n1,2,3,4\n5,6,7,8"
names = ["A", "B", "C", "D"]
parser = all_parsers
Expand Down
0