8000 Remove unnecessary casts in tokenizer.c by WillAyd · Pull Request #37792 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Remove unnecessary casts in tokenizer.c #37792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2020
Merged

Remove unnecessary casts in tokenizer.c #37792

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d020fb
reduced casting in tokenizer
WillAyd Nov 12, 2020
5e6e9e6
lint fixup
WillAyd Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lint fixup
  • Loading branch information
@WillAyd
WillAyd committed Nov 12, 2020
commit 5e6e9e672e37b9913cab5876bf5c0f4a26b46727
2 changes: 1 addition & 1 deletion pandas/_libs/src/parser/tokenizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1830,7 +1830,7 @@ double round_trip(const char *p, char **q, char decimal, char sci, char tsep,
if (q != NULL) {
// p and pc are different len due to tsep removal. Can't report
// how much it has consumed of p. Just rewind to beginning.
*q = (char *)p; // TODO: this could be undefined behavior
*q = (char *)p; // TODO(willayd): this could be undefined behavior
}
}
if (maybe_int != NULL) *maybe_int = 0;
Expand Down
0