10000 REGR: pd.to_hdf(..., dropna=True) not dropping missing rows by arw2019 · Pull Request #37564 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

REGR: pd.to_hdf(..., dropna=True) not dropping missing rows #37564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 4, 2020
+24 −5
Merged

REGR: pd.to_hdf(..., dropna=True) not dropping missing rows #37564

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1e8fb8c
TST: add tests for to_hdf with dropna arg
arw2019 Nov 1, 2020
d6e7681
BUG: add missing val handling to HDFStore.put
arw2019 Nov 1, 2020
d575b3a
DOC: add whatsnew
arw2019 Nov 1, 2020
b477931
TYP: fix type hint to silence mypy complaint
arw2019 Nov 1, 2020
379032e
DOC (feedback): move whatsnew
arw2019 Nov 2, 2020
3e22ef6
Merge remote-tracking branch 'upstream/master' into GH35719
arw2019 Nov 2, 2020
fe680a5
Merge remote-tracking branch 'upstream/master' into GH35719
arw2019 Nov 2, 2020
8b257e7
merge master
arw2019 Nov 3, 2020
5042e63
Merge remote-tracking branch 'upstream/master' into GH35719
arw2019 Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
DOC: add whatsnew
  • Loading branch information
@arw2019
arw2019 committed Nov 1, 2020
commit d575b3af67b85568499d3c5655598a26217e29de
3 changes: 1 addition & 2 deletions doc/source/whatsnew/v1.1.5.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ including other versions of pandas.

Fixed regressions
~~~~~~~~~~~~~~~~~
-
-
- Fixed regression in :meth:`DataFrame.to_hdf` was not dropping missing rows with ``dropna=True`` (:issue:`35719`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been quite a while, move this to 1.2

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


.. ---------------------------------------------------------------------------

Expand Down
0