8000 TYP: core/dtypes/cast.py by arw2019 · Pull Request #37024 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

TYP: core/dtypes/cast.py #37024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 14, 2020
Merged

TYP: core/dtypes/cast.py #37024

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b4e582f
add type hints
arw2019 Oct 10, 2020
2cc7e97
feedback
arw2019 Oct 10, 2020
8da843d
more type hints
arw2019 Oct 10, 2020
fc757c0
more type hints
arw2019 Oct 10, 2020
8999b35
remove addressed TODO
arw2019 Oct 10, 2020
d054868
add type hints to maybe_casted_values
arw2019 Oct 11, 2020
92d94b0
remove type hint from codes pending followon PR
arw2019 Oct 11, 2020
a5e9800
feedback: invalidate_string_dtype
arw2019 Oct 11, 2020
afd887b
feedback: add assert to maybe_castable
arw2019 Oct 11, 2020
7f4e93e
feedback: update docstring [convert_dtypes]
arw2019 Oct 12, 2020
3be4aba
feedback: revert variable type annotation in maybe_casted_values
arw2019 Oct 12, 2020
25ce7ed
revert annotations and add TODO for maybe_cast_to_EA
arw2019 Oct 12, 2020
3aa7e4d
use Dtype in maybe_cast_to_integer_array
arw2019 Oct 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more type hints
  • Loading branch information
@arw2019
arw2019 committed Oct 13, 2020
commit 8da843d1bda5723075b0cd07fb297ce7ace1d4ae
5 changes: 2 additions & 3 deletions pandas/core/dtypes/cast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,10 @@
notna,
)

from pandas.core.indexes.datetimes import DatetimeIndex

if TYPE_CHECKING:
from pandas import Series
from pandas.core.arrays import ExtensionArray
from pandas.core.indexes.datetimes import DatetimeIndex

_int8_max = np.iinfo(np.int8).max
_int16_max = np.iinfo(np.int16).max
Expand Down Expand Up @@ -1087,7 +1086,7 @@ def astype_nansafe(

def maybe_convert_objects(
values: np.ndarray, convert_numeric: bool = True
) -> Union[np.ndarray, DatetimeIndex]:
) -> Union[np.ndarray, "DatetimeIndex"]:
"""
If we have an object dtype array, try to coerce dates and/or numbers.

Expand Down
0