move tests to indexing/test_partial, add whatsnew entry

pandas-dev · jreback · Oct 26, 2020 · Oct 10, 2020 · Oct 10, 2020 · Oct 10, 2020
commit 25b229c425765bec6e9203a30fade4ced199ff15
diff --git a/doc/source/whatsnew/v1.1.4.rst b/doc/source/whatsnew/v1.1.4.rst
@@ -17,6 +17,7 @@ Fixed regressions
 - Fixed regression where attempting to mutate a :class:`DateOffset` object would no longer raise an ``AttributeError`` (:issue:`36940`)
 - Fixed regression where :meth:`DataFrame.agg` would fail with :exc:`TypeError` when passed positional arguments to be passed on to the aggregation function (:issue:`36948`).
 - Fixed regression in :class:`RollingGroupby` with ``sort=False`` not being respected (:issue:`36889`)
+- Fixed regression where slicing :class:`DatetimeIndex` failed on irregular time series with `pd.NaT` or on unsorted indices (:issue:`36953` and :issue:`35509`)
 
 .. ---------------------------------------------------------------------------
 

diff --git a/pandas/tests/frame/test_timeseries.py b/pandas/tests/frame/test_timeseries.py
@@ -64,21 +64,3 @@ def test_datetime_assignment_with_NaT_and_diff_time_units(self):
         )
         tm.assert_frame_equal(result, expected)
 
-    def test_slice_irregular_datetime_index_with_nan(self):
-        # GH36953
-        index = pd.to_datetime(["2012-01-01", "2012-01-02", "2012-01-03", None])
-        df = pd.DataFrame(range(len(index)), index=index)
-        expected = pd.DataFrame(range(len(index[:3])), index=index[:3])
-        tm.assert_frame_equal(df["2012-01-01":"2012-01-04"], expected)
-
-    def test_slice_datetime_index(self):
-        # GH35509
-        df = pd.DataFrame(
-            {"col1": ["a", "b", "c"], "col2": [1, 2, 3]},
-            index=pd.to_datetime(["2020-08-01", "2020-07-02", "2020-08-05"]),
-        )
-        expected = pd.DataFrame(
-            {"col1": ["a", "c"], "col2": [1, 3]},
-            index=pd.to_datetime(["2020-08-01", "2020-08-05"]),
-        )
-        tm.assert_frame_equal(df.loc["2020-08"], expected)
diff --git a/pandas/tests/indexing/test_partial.py b/pandas/tests/indexing/test_partial.py
@@ -681,3 +681,22 @@ def test_index_name_empty(self):
             {"series": [1.23] * 4}, index=pd.RangeIndex(4, name="series_index")
         )
         tm.assert_frame_equal(df, expected)
+
+    def test_slice_irregular_datetime_index_with_nan(self):
+        # GH36953
+        index = pd.to_datetime(["2012-01-01", "2012-01-02", "2012-01-03", None])
+        df = pd.DataFrame(range(len(index)), index=index)
+        expected = pd.DataFrame(range(len(index[:3])), index=index[:3])
+        tm.assert_frame_equal(df["2012-01-01":"2012-01-04"], expected)
+
+    def test_slice_datetime_index(self):
+        # GH35509
+        df = pd.DataFrame(
+            {"col1": ["a", "b", "c"], "col2": [1, 2, 3]},
+                index=pd.to_datetime(["2020-08-01", "2020-07-02", "2020-08-05"]),
+        )
+        expected = pd.DataFrame(
+            {"col1": ["a", "c"], "col2": [1, 3]},
+            index=pd.to_datetime(["2020-08-01", "2020-08-05"]),
+        )
+        tm.assert_frame_equal(df.loc["2020-08"], expected)