-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
BUG: fix matplotlib warning on CN color #36981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e163302
TST: add failing test
ivanovmg ff57346
FIX: eliminate warning regarding uppercase color
ivanovmg 29ea95e
CLN: simplify if statements
ivanovmg a9d125d
REF: drop old way of handling CN colors
ivanovmg d489a10
REF: move _is_*_color funcs to module level
ivanovmg aa14f33
TYP/DOC: fix typing, add docs
ivanovmg 749d63a
CLN: remove resetwarnings
ivanovmg 25c0df0
REF: remove function _is_cn_color
ivanovmg 58cebb2
CLN: make if one-liner, reference GH issue
ivanovmg b4937b6
Merge branch 'master' into warnings/matplotlib
ivanovmg f003217
FIX: match exact warning message
ivanovmg 4f1178d
Merge branch 'master' into warnings/matplotlib
ivanovmg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
TYP/DOC: fix typing, add docs
- Loading branch information
commit aa14f33eddd2b8ee8b926587d1c6eb191fe595bf
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
# being a bit too dynamic | ||
from typing import Sequence, Union | ||
import warnings | ||
|
||
import matplotlib.cm as cm | ||
|
@@ -79,24 +78,36 @@ def random_color(column): | |
|
||
def _is_cn_color(color: str) -> bool: | ||
"""Check if color string is CN color, like 'C0', 'C1', etc.""" | ||
return bool(color in ["C" + str(x) for x in range(10)]) | ||
cn_colors = ["C" + str(x) for x in range(10)] | ||
return bool(color in cn_colors) | ||
|
||
|
||
def _is_single_color(colors: Union[str, Sequence[str]]) -> bool: | ||
"""Check if ``colors`` is a single color. | ||
def _is_single_color(color: str) -> bool: | ||
"""Check if ``color`` is a single color. | ||
|
||
Examples of single colors: | ||
- 'r' | ||
- 'g' | ||
- 'red' | ||
- 'green' | ||
- 'C3' | ||
|
||
Parameters | ||
---------- | ||
color : string | ||
Color string. | ||
|
||
Returns | ||
------- | ||
bool | ||
True if ``color`` looks like a valid color. | ||
False otherwise. | ||
""" | ||
conv = matplotlib.colors.ColorConverter() | ||
if _is_cn_color(colors): | ||
if _is_cn_color(color): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct! It turns out that we can make it even cleaner. |
||
return True | ||
try: | ||
conv.to_rgba(colors) | ||
conv.to_rgba(color) | ||
except ValueError: | ||
return False | ||
else: | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default matplotlib color cycle has 10 colors, but if set differently this test won't be valid.