10000 BUG: propagate dropna in pd.Grouper by arw2019 · Pull Request #36604 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: propagate dropna in pd.Grouper #36604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 26, 2020
Merged

BUG: propagate dropna in pd.Grouper #36604

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f0b500d
add dropna attribute to BaseGrouper
arw2019 Sep 24, 2020
c913916
add tests
arw2019 Sep 24, 2020
ff6e013
propagate dropna in get_grouper
arw2019 Sep 24, 2020
d0cdc36
feedback
arw2019 Sep 25, 2020
dc56632
Merge remote-tracking branch 'upstream/master' into GH35612-grouper
arw2019 Sep 25, 2020
8e3c9fa
update Grouper doctring
arw2019 Sep 25, 2020
38a74ac
whatsnew
arw2019 Sep 25, 2020
2cf3c29
Merge remote-tracking branch 'upstream/master' into GH35612-grouper
arw2019 Sep 25, 2020
85f82b7
remove whatsnew note
arw2019 Sep 25, 2020
da53b6c
Merge remote-tracking branch 'upstream/master' into GH35612-grouper
arw2019 Sep 25, 2020
61f0553
added PR number to test
arw2019 Sep 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove whatsnew note
  • Loading branch information
@arw2019
arw2019 committed Sep 25, 2020
commit 85f82b75bf2cd618da970b35caf3c6e9a8ae2e2d
1 change: 0 additions & 1 deletion doc/source/whatsnew/v1.2.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,6 @@ Groupby/resample/rolling
- Bug in :meth:`DataFrame.groupby` does not always maintain column index name for ``any``, ``all``, ``bfill``, ``ffill``, ``shift`` (:issue:`29764`)
- Bug in :meth:`DataFrameGroupBy.apply` raising error with ``np.nan`` group(s) when ``dropna=False`` (:issue:`35889`)
- Bug in :meth:`Rolling.sum()` returned wrong values when dtypes where mixed between float and integer and axis was equal to one (:issue:`20649`, :issue:`35596`)
- Bug in :class:`pd.Grouper` now propagates ``dropna`` argument correctly (:issue:`36620`)

Reshaping
^^^^^^^^^
Expand Down
0