8000 CI/BLD: Restrict ci/code_checks.sh to tracked repo files by plammens · Pull Request #36386 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

CI/BLD: Restrict ci/code_checks.sh to tracked repo files #36386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

CI/BLD: Restrict ci/code_checks.sh to tracked repo files #36386

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
39c0c0e
BLD: refactor validate_unwanted_patterns.py
plammens Sep 15, 2020
ac8c5f7
BLD: fix ignored path checking in validate_unwanted_patterns.py
plammens Sep 15, 2020
b3d98f6
BLD: allow multiple path arguments in validate_unwanted_patterns.py
plammens Sep 15, 2020
d2dc5f7
BLD: add verbose option to validate_unwanted_patterns.py
plammens Sep 15, 2020
633abc4
BLD: add --no-override flag to validate_unwanted_patterns.py
plammens Sep 15, 2020
b70bc5d
BLD: restrict code_checks.sh to tracked repo files
plammens Sep 15, 2020
21feb52
CLN: clean up new detected trailing whitespace
plammens Sep 15, 2020
8611fe6
BLD: refactor code_checks.sh to avoid duplication due to GH Actions c…
plammens Sep 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
BLD: refactor code_checks.sh to avoid duplication due to GH Actions c… 
…heck
  • Loading branch information
@plammens
plammens committed Sep 23, 2020
commit 8611fe68aa9b13936d240e65d3bb6d3e3afc4dbc
42 changes: 22 additions & 20 deletions ci/code_checks.sh
8000 View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,20 @@ else
FLAKE8_FORMAT="default"
fi


function if_gh_actions {
# If this is running on GitHub Actions, echo the argument list, otherwise
# echo the empty string.
# Used to conditionally pass command-line arguments as in
# $(if_gh_actions --baz spam) | xargs foo --bar
if [[ "$GITHUB_ACTIONS" == "true" ]]; then
for arg in "$@"; do echo $arg; done | quote_if_needed
else
echo ""
fi
}


### LINTING ###
if [[ -z "$CHECK" || "$CHECK" == "lint" ]]; then

Expand Down Expand Up @@ -126,35 +140,23 @@ if [[ -z "$CHECK" || "$CHECK" == "lint" ]]; then
VALIDATE_CMD=$BASE_DIR/scripts/validate_unwanted_patterns.py

MSG='Check for use of not concatenated strings' ; echo $MSG
if [[ "$GITHUB_ACTIONS" == "true" ]]; then
echo $GIT_TRACKED_ALL_PY_FILES | xargs $VALIDATE_CMD --validation-type="strings_to_concatenate" --format="##[error]{source_path}:{line_number}:{msg}" --no-override
else
echo $GIT_TRACKED_ALL_PY_FILES | xargs $VALIDATE_CMD --validation-type="strings_to_concatenate" --no-override
fi
ARGS=$({ if_gh_actions --format="##[error]{source_path}:{line_number}:{msg}"; echo $GIT_TRACKED_ALL_PY_FILES; })
echo $ARGS | xargs $VALIDATE_CMD --validation-type="strings_to_concatenate" --no-override
RET=$(($RET + $?)) ; echo $MSG "DONE"

MSG='Check for strings with wrong placed spaces' ; echo $MSG
if [[ "$GITHUB_ACTIONS" == "true" ]]; then
echo $GIT_TRACKED_ALL_PY_FILES | xargs $VALIDATE_CMD --validation-type="strings_with_wrong_placed_whitespace" --format="##[error]{source_path}:{line_number}:{msg}" --no-override
else
echo $GIT_TRACKED_ALL_PY_FILES | xargs $VALIDATE_CMD --validation-type="strings_with_wrong_placed_whitespace" --no-override
fi
ARGS=$({ if_gh_actions --format="##[error]{source_path}:{line_number}:{msg}"; echo $GIT_TRACKED_ALL_PY_FILES; })
echo $ARGS | xargs $VALIDATE_CMD --validation-type="strings_with_wrong_placed_whitespace" --no-override
RET=$(($RET + $?)) ; echo $MSG "DONE"

MSG='Check for import of private attributes across modules' ; echo $MSG
if [[ "$GITHUB_ACTIONS" == "true" ]]; then
$VALIDATE_CMD --validation-type="private_import_across_module" --included-file-extensions="py" --excluded-file-paths=pandas/tests,asv_bench/,pandas/_vendored --format="##[error]{source_path}:{line_number}:{msg}" pandas/
else
$VALIDATE_CMD --validation-type="private_import_across_module" --included-file-extensions="py" --excluded-file-paths=pandas/tests,asv_bench/,pandas/_vendored pandas/
fi
ARGS=$(if_gh_actions --format="##[error]{source_path}:{line_number}:{msg}")
echo $ARGS | xargs $VALIDATE_CMD --validation-type="private_import_across_module" --included-file-extensions="py" --excluded-file-paths=pandas/tests,asv_bench/,pandas/_vendored pandas/
RET=$(($RET + $?)) ; echo $MSG "DONE"

MSG='Check for use of private functions across modules' ; echo $MSG
if [[ "$GITHUB_ACTIONS" == "true" ]]; then
$VALIDATE_CMD --validation-type="private_function_across_module" --included-file-extensions="py" --excluded-file-paths=pandas/tests,asv_bench/,pandas/_vendored,doc/ --format="##[error]{source_path}:{line_number}:{msg}" pandas/
else
$VALIDATE_CMD --validation-type="private_function_across_module" --included-file-extensions="py" --excluded-file-paths=pandas/tests,asv_bench/,pandas/_vendored,doc/ pandas/
fi
ARGS=$(if_gh_actions --format="##[error]{source_path}:{line_number}:{msg}")
echo $ARGS | xargs $VALIDATE_CMD --validation-type="private_function_across_module" --included-file-extensions="py" --excluded-file-paths=pandas/tests,asv_bench/,pandas/_vendored,doc/ pandas/
RET=$(($RET + $?)) ; echo $MSG "DONE"

echo "isort --version-number"
Expand Down
0