8000 Issues #194 (cov function) and #92 (multi-column sort) by changhiskhan · Pull Request #362 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Issues #194 (cov function) and #92 (multi-column sort) #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Issues #194 (cov function) and #92 (multi-column sort) #362

wants to merge 6 commits into from

Conversation

changhiskhan
Copy link
Contributor

Added:

  1. Series.cov
  2. DataFrame.cov
  3. test_cov in test_series.py
  4. test_cov in test_frame.py

Modified:

  1. DataFrame.sort
  2. DataFrame.sort_index
  3. test_sort in test_frame.py

@wesm
Copy link
Member
wesm commented Nov 13, 2011

In the future you should make these commits in a feature branch instead of master-- I'll have to cherry-pick these commits but then you should clean up your master branch to not have any merge commits-- after I take your commits you should reset to a state prior to this work then pull wesm/master...git-fu =)

wesm
wesm reviewed Nov 13, 2011
View reviewed changes
pandas/core/series.py
def _get_nonna_aligned(self, other):
"""
Returns two sub-Series with the same index and only non-na values
"""
commonIdx = self.dropna().index.intersection(other.dropna().index)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also do:

this, that = self.dropna().align(other.dropna(), join='inner')

@wesm
Copy link
Member
wesm commented Nov 13, 2011

You should also set your e-mail address in your global git config

@wesm
Copy link
Member
wesm commented Nov 13, 2011

OK I cherry picked and amended your commits and merged them in. Thanks a lot for the PR-- I'll make a few little edits and see if there's a more performant way to do multi-column sorting.

Also pls stick to 80 chars per column / other pep8 conventions

@wesm wesm closed this Nov 13, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@changhiskhan @wesm
0