8000 ENH: Add validation checks for non-unique merge keys by LewisDavies · Pull Request #35373 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

ENH: Add validation checks for non-unique merge keys #35373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

ENH: Add validation checks for non-unique merge keys #35373

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e6f677
Add many-to-many merge validation check
LewisDavies Jul 22, 2020
ebe7be9
Extend checks to 1:m and m:1 merges
LewisDavies Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Extend checks to 1:m and m:1 merges
  • Loading branch information
@LewisDavies
LewisDavies committed Jul 22, 2020
commit ebe7be9d95f3ee60fc55e86918978c7de5b7376d
14 changes: 10 additions & 4 deletions pandas/core/reshape/merge.py
View file
Open in desktop
9D41
Original file line number Diff line numberDiff line change
Expand Up @@ -1283,24 +1283,30 @@ def _validate(self, validate: str):
raise MergeError(
"Merge keys are not unique in left dataset; not a one-to-many merge"
)
elif right_unique:
raise MergeError(
"Merge keys are unique in right dataset; not a one-to-many merge"
)

elif validate in ["many_to_one", "m:1"]:
if not right_unique:
raise MergeError(
"Merge keys are not unique in right dataset; "
"not a many-to-one merge"
)
elif left_unique:
raise MergeError(
"Merge keys are unique in left dataset; not a many-to-one merge"
)

elif validate in ["many_to_many", "m:m"]:
if left_unique:
raise MergeError(
"Merge keys are unique in the left dataset;"
"not a many-to-many merge"
"Merge keys are unique in left dataset; not a many-to-many merge"
)
elif right_unique:
raise MergeError(
"Merge keys are unique in the right dataset;"
"not a many-to-many merge"
"Merge keys are unique in right dataset; not a many-to-many merge"
)

else:
Expand Down
0