8000 ENH: add percentage threshold to dropna by erfannariman · Pull Request #35300 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

ENH: add percentage threshold to dropna #35300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

ENH: add percentage threshold to dropna #35300

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3db34b7
35299 - added perc threshold argument
erfannariman Jul 15, 2020
384d459
35299 - test for perc in dropna
erfannariman Jul 15, 2020
1085375
35299 - added docstring
erfannariman Jul 15, 2020
c2f0386
35299 - removed redundant code
erfannariman Jul 15, 2020
3886354
35299 - fixed docstring
erfannariman Jul 15, 2020
2129362
Merge branch 'master' into 35299_add_perc_dropna
erfannariman Jul 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
35299 - removed redundant code
  • Loading branch information
@erfannariman
erfannariman committed Jul 15, 2020
commit c2f0386a21bdd2731e155e3b4437f8536706f3f1
8 changes: 1 addition & 7 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5012,13 +5012,7 @@ def dropna(
else:
raise TypeError("must specify how or thresh")

if perc is not None:
if axis == 0:
result = self.loc[mask, :]
else:
result = self.loc[:, mask]
else:
result = self.loc(axis=axis)[mask]
result = self.loc(axis=axis)[mask]

if inplace:
self._update_inplace(result)
Expand Down
0