8000 ENH: make is_list_like handle non iterable numpy-like arrays correctly by znicholls · Pull Request #35127 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

ENH: make is_list_like handle non iterable numpy-like arrays correctly #35127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

ENH: make is_list_like handle non iterable numpy-like arrays correctly #35127

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0ecb8c2
Add failing test
znicholls Feb 13, 2021
ad5f714
Add __array__ method to mock numpy-like
znicholls Feb 13, 2021
139493f
TST: GH35131 Add failing test of numpy-like array handling
znicholls Jul 5, 2020
ba59fb8
ENH: GH35131 Implement fix which allows numpy-like handling
znicholls Jul 5, 2020
451fbfc
Simplify ndim check
znicholls Jul 5, 2020
57e186b
Revert change because it broke tests
znicholls Jul 6, 2020
590c2a2
Use slightly clearer logic
znicholls Jul 6, 2020
27bd4e4
Update to use numpy iterable
znicholls Jul 7, 2020
d9a2c8f
Add failing is_scalar tests
znicholls Jul 7, 2020
764e7b1
Revert to relying on python's shortcircuit operators
znicholls Jul 7, 2020
088dff8
Make a mess
znicholls Feb 13, 2021
928842f
Fix missing module
znicholls Feb 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert to relying on python's shortcircuit operators 
Also avoid np.iterable
  • Loading branch information
@znicholls
znicholls committed Feb 13, 2021
commit 764e7b1045fa7ba9ffa587bdb54fac0e66f2f345
4 changes: 3 additions & 1 deletion pandas/_libs/lib.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1044,7 +1044,9 @@ def is_list_like(obj: object, allow_sets: bool = True) -> bool:

cdef inline bint c_is_list_like(object obj, bint allow_sets) except -1:
return (
np.iterable(obj)
isinstance(obj, abc.Iterable)
# avoid numpy-style scalars
and not (hasattr(obj, "ndim") and obj.ndim == 0)
# we do not count strings/unicode/bytes as list-like
and not isinstance(obj, (str, bytes))
# exclude sets if allow_sets is False
Expand Down
0