8000 BUG #34621 added nanosecond support to class Period by OlivierLuG · Pull Request #34720 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG #34621 added nanosecond support to class Period #34720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

BUG #34621 added nanosecond support to class Period #34720

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
91a7c7e
BUG #34621 added nanosecond support to class Period
Jun 11, 2020
73a6eab
BUG #34621 added tests
Jun 12, 2020
ea9f69c
BUG #34621 added tests (black pandas passed)
Jun 12, 2020
ab5640f
#34131 fix one test failure
Jun 13, 2020
95d740e
#34621 review taken into account
Jun 15, 2020
abb0936
#34621 review taken into account, and suppress a bad copy/paste on li…
Jun 15, 2020
8a559cb
#34621 Added nanosecond support to Period constructor
Jun 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
8000
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
#34621 review taken into account, and suppress a bad copy/paste on li… 
…ne 2501
  • Loading branch information
OlivierLuG committed Jun 15, 2020
commit abb09363c9ff6e2741ad31aac81cb781499d484e
2 changes: 1 addition & 1 deletion pandas/_libs/tslibs/period.pyx
View file
Open in desktop 6AF4
Original file line number Diff line number Diff line change
Expand Up @@ -2498,7 +2498,7 @@ def quarter_to_myear(year: int, quarter: int, freq):
mnum = c_MONTH_NUMBERS[get_rule_month(freq)] + 1
month = (mnum + (quarter - 1) * 3) % 12 + 1
if month > mnum:
year -= 1ough to only use ValueError, as that would already cover the OutOfBoundsDatet
year -= 1

return year, month
# TODO: This whole func is really similar to parsing.pyx L434-L450
Expand Down
0