8000 BUG: Fix value setting in case of merging via index on one side and column on other side. by phofl · Pull Request #34496 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: Fix value setting in case of merging via index on one side and column on other side. #34496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

BUG: Fix value setting in case of merging via index on one side and column on other side. #34496

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ef2d11f
BUG: Fix wrong values when joining via index and column for left, rig…
phofl May 31, 2020
f1f5647
Add whats new entry
phofl May 31, 2020
3a5a292
Fix whats new typo
phofl May 31, 2020
a3e6623
Change if condition
phofl May 31, 2020
e759612
Run black pandas
phofl May 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix whats new typo
  • Loading branch information
@phofl
phofl committed May 31, 2020
commit 3a5a29248d1c687e0b14a97c54d5a4e2d6e0b6b2
2 changes: 1 addition & 1 deletion doc/source/whatsnew/v1.1.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,7 +936,7 @@ Reshaping
- Bug in :meth:`DataFrame.replace` casts columns to ``object`` dtype if items in ``to_replace`` not in values (:issue:`32988`)
- Ensure only named functions can be used in :func:`eval()` (:issue:`32460`)
- Fixed bug in :func:`melt` where melting MultiIndex columns with ``col_level`` > 0 would raise a ``KeyError`` on ``id_vars`` (:issue:`34129`)
- Fixed bug setting wrong values in result when joining one side over index and other side over column in case of join type not equal to inner (:issue:`17257`, :issue`28220`, :issue:`28243`, :issue:`33232`)
- Fixed bug setting wrong values in result when joining one side over index and other side over column in case of join type not equal to inner (:issue:`17257`, :issue:`28220`, :issue:`28243` and :issue:`33232`)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what you are trying to fix by reading this. You are xrefing lots of issues, are you actually closing them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issues have to different problems.

1: The index is not handled right
2: The values of the join columns are wrong.

This PR fixes 2, #34468 should fix the other part. That is why I am only referencing them.


Sparse
^^^^^^
Expand Down
0