8000 BUG: Fix concat of frames with extension types (no reindexed columns) by jorisvandenbossche · Pull Request #34339 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: Fix concat of frames with extension types (no reindexed columns) #34339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jun 19, 2020
Merged

BUG: Fix concat of frames with extension types (no reindexed columns) #34339

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e130060
BUG: Fix concat of frames with extension types (no reindexed columns)
jorisvandenbossche May 23, 2020
ea33cfd
Merge remote-tracking branch 'upstream/master' into EA-concat-frame
jorisvandenbossche May 23, 2020
f83338a
clean-up
jorisvandenbossche May 23, 2020
5822694
fix concat of DatetimeBlock / DatetimeTZBlock to not take 'uniform' path
jorisvandenbossche May 23, 2020
3d32bc8
fix base extension tests
jorisvandenbossche May 23, 2020
951e356
Merge remote-tracking branch 'upstream/master' into EA-concat-frame
jorisvandenbossche Jun 6, 2020
d269229
fix test
jorisvandenbossche Jun 6, 2020
63a6570
add whatsnew
jorisvandenbossche Jun 6, 2020
e731802
Merge remote-tracking branch 'upstream/master' into EA-concat-frame
jorisvandenbossche Jun 15, 2020
d8faef5
update whatsnew
jorisvandenbossche Jun 15, 2020
2e1f1a6
Update doc/source/whatsnew/v1.1.0.rst
jorisvandenbossche Jun 18, 2020
94fe89d
Merge remote-tracking branch 'upstream/master' into EA-concat-frame
jorisvandenbossche Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix concat of DatetimeBlock / DatetimeTZBlock to not take 'uniform' path
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed May 23, 2020
commit 58226948ec6550dc021c1b06a81f8157e7c8d696
2 changes: 1 addition & 1 deletion 8000 pandas/core/internals/concat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ def _is_uniform_join_units(join_units: List[JoinUnit]) -> bool:
# cannot necessarily join
return (
# all blocks need to have the same type
all(isinstance(ju.block, type(join_units[0].block)) for ju in join_units)
all(type(ju.block) is type(join_units[0].block) for ju in join_units)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is to ensure DatetimeBlock and DatetimeTZBlock don't incorrectly take this "uniform join units" code path

and # noqa
# no blocks that would get missing values (can lead to type upcasts)
# unless we're an extension dtype.
Expand Down
0