8000 ENH: general concat with ExtensionArrays through find_common_type by jorisvandenbossche · Pull Request #33607 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

ENH: general concat with ExtensionArrays through find_common_type #33607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 2, 2020
Merged

ENH: general concat with ExtensionArrays through find_common_type #33607

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3464e95
initial find_common_type/_get_common_type + tests for IntegerDtype
jorisvandenbossche Apr 17, 2020
b1d9d68
handle categoricals
jorisvandenbossche Apr 17, 2020
bb398e7
handle sparse
jorisvandenbossche Apr 17, 2020
83fdc91
handle non-initialized CategoricalDtype in find_common_type
jorisvandenbossche Apr 17, 2020
7f2ac2a
handle datetimelike special case
jorisvandenbossche Apr 17, 2020
d0f90de
update docstring and comment
jorisvandenbossche Apr 17, 2020
2d5fcb0
ignore mypy
jorisvandenbossche Apr 17, 2020
a68206b
Merge remote-tracking branch 'upstream/master' into concat-protocol
jorisvandenbossche May 1, 2020
fc98b65
common_type -> commong_dtype
jorisvandenbossche May 1, 2020
b072591
ensure deduplicated list of dtypes is passed
jorisvandenbossche May 1, 2020
91c984a
add very basic base extension test
jorisvandenbossche May 1, 2020
2a2b9d5
document API change
jorisvandenbossche May 1, 2020
8893165
update EA interface docs
jorisvandenbossche May 1, 2020
e19e3ef
add type annotation on find_common_type
jorisvandenbossche May 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add type annotation on find_common_type
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed May 1, 2020
commit e19e3ef93d95a5d96f47812371d47c36af814245
4 changes: 2 additions & 2 deletions pandas/core/dtypes/cast.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"""

from datetime import date, datetime, timedelta
from typing import TYPE_CHECKING, Any, Optional, Tuple, Type
from typing import TYPE_CHECKING, Any, List, Optional, Tuple, Type

import numpy as np

Expand Down Expand Up @@ -1423,7 +1423,7 @@ def maybe_cast_to_datetime(value, dtype, errors: str = "raise"):
return value


def find_common_type(types):
def find_common_type(types: List[DtypeObj]) -> DtypeObj:
"""
Find a common data type among the given dtypes.

Expand Down
0