8000 REF: replace column-wise, remove BlockManager.apply filter kwarg by jbrockmendel · Pull Request #33340 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

REF: replace column-wise, remove BlockManager.apply filter kwarg #33340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 8, 2020
Merged

REF: replace column-wise, remove BlockManager.apply filter kwarg #33340

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9910af
REF: replace column-wise, remove BlockManager.apply filter kwarg
jbrockmendel Apr 6, 2020
456f501
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Apr 6, 2020
f94e2a2
mypy fixup
jbrockmendel Apr 6, 2020
8697b13
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Apr 6, 2020
dec71b0
implement _replace_columnwise
jbrockmendel Apr 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mypy fixup
  • Loading branch information
@jbrockmendel
jbrockmendel committed Apr 6, 2020
commit f94e2a2f9728596f72521c292cc8a3e4993a68b0
2 changes: 1 addition & 1 deletion pandas/core/internals/managers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,7 +391,7 @@ def apply(self: T, f, align_keys=None, **kwargs) -> T:
assert "filter" not in kwargs

align_keys = align_keys or []
result_blocks = []
result_blocks: List[Block] = []
# fillna: Series/DataFrame is responsible for making sure value is aligned

self._consolidate_inplace()
Expand Down
0