8000 REGR: Fix bug when replacing categorical value with self by dsaxton · Pull Request #33292 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

REGR: Fix bug when replacing categorical value with self #33292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 6, 2020
Merged

REGR: Fix bug when replacing categorical value with self #33292

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5b3c4c5
BUG: Fix bug when replacing categorical value with self
dsaxton Apr 4, 2020
1c757f9
Merge remote-tracking branch 'upstream/master' into replace-cat
dsaxton Apr 4, 2020
5ac4061
Merge remote-tracking branch 'upstream/master' into replace-cat
dsaxton Apr 5, 2020
696eea9
Test comment
dsaxton Apr 5, 2020
9be0d1b
Check earlier
dsaxton Apr 5, 2020
2f717bc
Merge remote-tracking branch 'upstream/master' into replace-cat
dsaxton Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test comment
  • Loading branch information
@dsaxton
dsaxton committed Apr 5, 2020
commit 696eea95bc583571f8f0bf876b5763620b2b0458
1 change: 1 addition & 0 deletions pandas/tests/arrays/categorical/test_algos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ def test_isin_cats():
[
("b", "c", ["a", "c"], "Categorical.categories are different"),
("c", "d", ["a", "b"], None),
# https://github.com/pandas-dev/pandas/issues/33288
("a", "a", ["a", "b"], None),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you annotate this case (add a comment on line before with this issue number)

("b", None, ["a", None], "Categorical.categories length are different"),
],
Expand Down
0