8000 Switch dataframe constructor to use dispatch by saulshanabrook · Pull Request #32844 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Switch dataframe constructor to use dispatch #32844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Switch dataframe constructor to use dispatch #32844

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6fe0831
Switch dataframe constructor to use dispatch
saulshanabrook Mar 19, 2020
e123ab4
blacken
saulshanabrook Mar 19, 2020
4dfb4b7
flake8
saulshanabrook Mar 19, 2020
522029d
mypy fixes
saulshanabrook Mar 19, 2020
b8dd353
style fixes
saulshanabrook Mar 19, 2020
7259590
Merge pandas/master into rework-constructor
saulshanabrook Mar 19, 2020
3e4b466
rename and take class instead of instance
saulshanabrook Mar 19, 2020
898e3d7
Move create_dataframe to construction
saulshanabrook Mar 19, 2020
7e82826
Sort imports
saulshanabrook Mar 19, 2020
b307c4b
Fix calling
saulshanabrook Mar 19, 2020
edd85c3
Add test for custom constructor
saulshanabrook Mar 20, 2020
8240d86
Added whats new
saulshanabrook Mar 20, 2020
b856214
unused imports
saulshanabrook Mar 20, 2020
a4b3ed0
Merge pandas/master into rework-constructor
saulshanabrook Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
mypy fixes
  • Loading branch information
@saulshanabrook
saulshanabrook committed Mar 19, 2020
commit 522029d34726f348619dde5c4c7de82561e23cae
8 changes: 3 additions & 5 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8569,15 +8569,13 @@ class _IterableExceptStringOrBytes(metaclass=_IterableExceptStringOrBytesMeta):
pass


@create_block_manager.register
def _create_block_manager_iterable(
data: _IterableExceptStringOrBytes, df, index, columns, dtype, copy
):
@create_block_manager.register(_IterableExceptStringOrBytes)
def _create_block_manager_iterable(data: abc.Iterable, df, index, columns, dtype, copy):
if not isinstance(data, (abc.Sequence, ExtensionArray)):
data = list(data)
if len(data) > 0:
if is_dataclass(data[0]):
data = dataclasses_to_dicts(data)
data = cast(List[dict], dataclasses_to_dicts(data))
if is_list_like(data[0]) and getattr(data[0], "ndim", 1) == 1:
if is_named_tuple(data[0]) and columns is None:
columns = data[0]._fields
Expand Down
0