8000 BUG: DataFrame fail to construct when data is list and columns is nested list for MI by charlesdong1991 · Pull Request #32202 · pandas-dev/pandas · GitHub
[go: up one dir, main page]

Skip to content

BUG: DataFrame fail to construct when data is list and columns is nested list for MI #32202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Apr 6, 2020
Merged
Changes from 1 commit
Commits
Show all changes
44 commits
Select commit Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 Dec 3, 2018
1314059
fix conflicts
charlesdong1991 Jan 19, 2019
8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Jul 30, 2019
24c3ede
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Jan 14, 2020
dea38f2
fix issue 17038
charlesdong1991 Jan 14, 2020
cd9e7ac
revert change
charlesdong1991 Jan 14, 2020
e5e912b
revert change
charlesdong1991 Jan 14, 2020
e609188
Merge remote-tracking branch 'upstream/master' into fix_issue_32173
charlesdong1991 Feb 23, 2020
c8ee822
fix 32173
charlesdong1991 Feb 23, 2020
07ffde2
linting
charlesdong1991 Feb 23, 2020
b3f3da0
linting
charlesdong1991 Feb 23, 2020
2f2054c
add whatsnew
charlesdong1991 Feb 23, 2020
9176389
fix linting
charlesdong1991 Feb 23, 2020
ed02384
Merge remote-tracking branch 'upstream/master' into fix_issue_32173
charlesdong1991 Feb 23, 2020
d3b0c50
rebase and resolve conflict
charlesdong1991 Mar 4, 2020
a5e0d10
separate out column validation
charlesdong1991 Mar 4, 2020
6073ed7
code change based on JR review
charlesdong1991 Mar 4, 2020
e8f6d67
fixup
charlesdong1991 Mar 4, 2020
559b5d6
fixup
charlesdong1991 Mar 4, 2020
a452816
Merge remote-tracking branch 'upstream/master' into fix_issue_32173
charlesdong1991 Mar 5, 2020
3fd6743
rebase and fix conflict
charlesdong1991 Mar 15, 2020
2428edb
add docs and annotation
charlesdong1991 Mar 15, 2020
fe18e50
black
charlesdong1991 Mar 15, 2020
a5d159b
Add more docs
charlesdong1991 Mar 15, 2020
7516964
add annotation
charlesdong1991 Mar 15, 2020
86bd699
add for dict
charlesdong1991 Mar 15, 2020
30a70a7
remove unused import
charlesdong1991 Mar 15, 2020
a6cb139
Merge remote-tracking branch 'upstream/master' into fix_issue_32173
charlesdong1991 Apr 2, 2020
ed6dc4a
improve annotation
charlesdong1991 Apr 2, 2020
f058d2c
fix annotation
charlesdong1991 Apr 2, 2020
2852579
fix annotation
charlesdong1991 Apr 2, 2020
493ac33
fixup
charlesdong1991 Apr 2, 2020
3ecd6b8
more details
charlesdong1991 Apr 3, 2020
851a3e1
isort
charlesdong1991 Apr 3, 2020
9860985
better annotation
charlesdong1991 Apr 3, 2020
ffc6561
removed unused import
charlesdong1991 Apr 3, 2020
a028c33
linting
charlesdong1991 Apr 3, 2020
5af0f8e
code change on JB review
charlesdong1991 Apr 3, 2020
9eda16a
fixup
charlesdong1991 Apr 3, 2020
35e92ea
Merge remote-tracking branch 'upstream/master' into fix_issue_32173
charlesdong1991 Apr 3, 2020
44af738
fix conflicts
charlesdong1991 Apr 4, 2020
d0a10e4
Merge remote-tracking branch 'upstream/master' into fix_issue_32173
charlesdong1991 Apr 5, 2020
1700e5d
Merge remote-tracking branch 'upstream/master' into fix_issue_32173
charlesdong1991 Apr 6, 2020
8a036e4
Merge remote-tracking branch 'upstream/master' into fix_issue_32173
charlesdong1991 Apr 6, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
charlesdong1991 committed Mar 4, 2020
commit e8f6d6738ccef2f4c5cc2fd2a54544a11c0706e5
10 changes: 6 additions & 4 deletions pandas/core/internals/construction.py
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,8 @@ def to_arrays(data, columns, coerce_float=False, dtype=None):
return [[]] * len(columns), columns
return [], [] # columns if columns is not None else []
if isinstance(data[0], (list, tuple)):
return _list_to_arrays(data, columns, coerce_float=coerce_float, dtype=dtype)
columns = _validate_or_indexify_columns(data, columns)
return _list_to_arrays(data, coerce_float=coerce_float, dtype=dtype), columns
elif isinstance(data[0], abc.Mapping):
return _list_of_dict_to_arrays(
data, columns, coerce_float=coerce_float, dtype=dtype
Expand All @@ -481,10 +482,11 @@ def to_arrays(data, columns, coerce_float=False, dtype=None):
else:
# last ditch effort
data = [tuple(x) for x in data]
return _list_to_arrays(data, columns, coerce_float=coerce_float, dtype=dtype)
columns = _validate_or_indexify_columns(data, columns)
return _list_to_arrays(data, coerce_float=coerce_float, dtype=dtype), columns


def _list_to_arrays(data, columns, coerce_float=False, dtype=None):
def _list_to_arrays(data, coerce_float=False, dtype=None):
if len(data) > 0 and isinstance(data[0], tuple):
content = list(lib.to_object_array_tuples(data).T)
else:
Expand All @@ -493,7 +495,7 @@ def _list_to_arrays(data, columns, coerce_float=False, dtype=None):
# gh-26429 do not raise user-facing AssertionError
try:
result = _convert_object_array(
content, columns, dtype=dtype, coerce_float=coerce_float
content, dtype=dtype, coerce_float=coerce_float
)
except AssertionError as e:
raise ValueError(e) from e
Expand Down
0