10000 BUG: Array.__setitem__ failing with nullable boolean mask by charlesdong1991 · Pull Request #31484 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: Array.__setitem__ failing with nullable boolean mask #31484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Feb 1, 2020
Merged

BUG: Array.__setitem__ failing with nullable boolean mask #31484

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 Dec 3, 2018
1314059
fix conflicts
charlesdong1991 Jan 19, 2019
8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Jul 30, 2019
24c3ede
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Jan 14, 2020
dea38f2
fix issue 17038
charlesdong1991 Jan 14, 2020
cd9e7ac
revert change
charlesdong1991 Jan 14, 2020
e5e912b
revert change
charlesdong1991 Jan 14, 2020
f8661e3
Merge remote-tracking branch 'upstream/master' into fix_issue_31446
charlesdong1991 Jan 31, 2020
355dce9
issue 31446
charlesdong1991 Jan 31, 2020
e1c53f0
add test
charlesdong1991 Jan 31, 2020
bc2add3
add whatsnew
charlesdong1991 Jan 31, 2020
82cbaed
code change on reviews
charlesdong1991 Jan 31, 2020
5950455
add string
charlesdong1991 Jan 31, 2020
e3bf159
change test
charlesdong1991 Jan 31, 2020
f7c6357
add for all
charlesdong1991 Jan 31, 2020
64f2359
remove redundent imports
charlesdong1991 Jan 31, 2020
a4451ba
fixup
charlesdong1991 Jan 31, 2020
6554b49
fixup
charlesdong1991 Jan 31, 2020
9ad0cbe
skip pandasarray
charlesdong1991 Jan 31, 2020
edd4514
doc
charlesdong1991 Feb 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup
  • Loading branch information
@charlesdong1991
charlesdong1991 committed Jan 31, 2020
commit 6554b49aec0a8e7f7a51d82a6edeaf240e4fedd3
4 changes: 2 additions & 2 deletions pandas/tests/extension/base/setitem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,10 @@ def test_setitem_preserves_views(self, data):
assert view1[0] == data[1]
assert view2[0] == data[1]

def test_setitem_nullable_integer(self, data):
def test_setitem_nullable_mask(self, data):
# GH 31446
arr = data[:5]
expected = data.take([0, 0, 0, 3, 4])
mask = pd.array([True, True, True, False, False])
arr[mask] = arr[0]
arr[mask] = data[0]
self.assert_extension_array_equal(expected, arr)
0