8000 Backport PR: Series rolling count ignores min_periods by fujiaxiang · Pull Request #31320 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Backport PR: Series rolling count ignores min_periods #31320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 26, 2020
Merged

Backport PR: Series rolling count ignores min_periods #31320

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
74cba7d
BUG: Series rolling count ignores min_periods (GH26996)
fujiaxiang Jan 11, 2020
bd0fb50
ENH: handles min_periods argument in rolling.count (GH26996)
fujiaxiang Jan 17, 2020
61226b5
DOC: moved whatsnew to V1.1.0
fujiaxiang Jan 18, 2020
4a93069
TST: added more tests (GH26996)
fujiaxiang Jan 21, 2020
14a4fcb
BUG: updated rolling and expanding count for consistency (GH26996)
fujiaxiang Jan 21, 2020
4988b4f
CLN: further cleaned code (GH26996)
fujiaxiang Jan 22, 2020
1e48ac3
TST: cleaned up tests (GH26996)
fujiaxiang Jan 24, 2020
c091787
BUG: changed min_periods default to 0 for rolling and expanding (GH26…
fujiaxiang Jan 24, 2020
f905cbb
BUG: reverted non-relevant changes accidentally added (GH26996)
fujiaxiang Jan 24, 2020
0a27a21
BUG: small change in whatsnew (GH26996)
fujiaxiang Jan 25, 2020
337f1ae
CLN: slight cleanup (GH26996)
fujiaxiang Jan 25, 2020
12e1f09
removed redundant file
fujiaxiang Jan 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ENH: handles min_periods argument in rolling.count (GH26996)
  • Loading branch information
@fujiaxiang
fujiaxiang committed Jan 26, 2020
commit bd0fb503e5d311042ef32f0a424d2759137cab4b
10 changes: 8 additions & 2 deletions pandas/core/window/rolling.py
86E3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1185,8 +1185,14 @@ def count(self):

window = self._get_window()
window = min(window, len(obj)) if not self.center else window
min_periods = self.min_periods if self.min_periods is not None else 0
min_periods = min(min_periods, len(obj)) if not self.center else min_periods

# We set the default value min_periods to be 0 because count method
# is meant to count NAs, we don't want it by default requires all
# values in the window to be valid to produce a valid count
min_periods = 0 if self.min_periods is None else self.min_periods

# this is required as window is mutate above
min_periods = min(min_periods, window)

results = []
for b in blocks:
Expand Down
0