8000 REF: use shareable code for DTI/TDI.insert by jbrockmendel · Pull Request #30806 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

REF: use shareable code for DTI/TDI.insert #30806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 9, 2020
Merged

REF: use shareable code for DTI/TDI.insert #30806

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ff4044b
REF: use shareable code for DTI/TDI.insert
jbrockmendel Jan 8, 2020
24ea5d4
flake8 fixup
jbrockmendel Jan 8, 2020
a39e50b
update tests
jbrockmendel Jan 8, 2020
ed4e2e7
update tests
jbrockmendel Jan 8, 2020
13b6be3
Merge branch 'master' of https://github.com/pandas-dev/pandas into re…
jbrockmendel Jan 8, 2020
7ff4fb8
whatsnew
jbrockmendel Jan 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update tests
  • Loading branch information
@jbrockmendel
jbrockmendel committed Jan 8, 2020
commit a39e50b657da0ec6307f5d62a08712ffcd1439e0
4 changes: 2 additions & 2 deletions pandas/tests/indexes/datetimes/test_indexing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,9 +434,9 @@ def test_insert(self):

# see gh-7299
idx = date_range("1/1/2000", periods=3, freq="D", tz="Asia/Tokyo", name="idx")
with pytest.raises(ValueError):
with pytest.raises(TypeError, match="Cannot compare tz-naive and tz-aware"):
idx.insert(3, pd.Timestamp("2000-01-04"))
with pytest.raises(ValueError):
with pytest.raises(TypeError, match="Cannot compare tz-naive and tz-aware"):
idx.insert(3, datetime(2000, 1, 4))
with pytest.raises(ValueError):
idx.insert(3, pd.Timestamp("2000-01-04", tz="US/Eastern"))
Expand Down
0