10000 DOC/TST: Indexing with NA raises by TomAugspurger · Pull Request #30308 · pandas-dev/pandas · GitHub
[go: up one dir, main page]

Skip to content

DOC/TST: Indexing with NA raises #30308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Jan 3, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
492f904
DOC/TST: Indexing with NA raises
TomAugspurger Dec 16, 2019
6444aa0
Merge remote-tracking branch 'upstream/master' into na-indexing-raises
TomAugspurger Dec 18, 2019
53f4f63
Handle BooleanArray in all EAs
TomAugspurger Dec 18, 2019
3bbf868
update
TomAugspurger Dec 18, 2019
a5ac457
fixups
TomAugspurger Dec 18, 2019
0dfe761
type
TomAugspurger Dec 18, 2019
dac111d
fix benchmark
TomAugspurger Dec 18, 2019
d1f08d9
fixup
TomAugspurger Dec 18, 2019
3dd59ca
typo
TomAugspurger Dec 18, 2019
151bdfe
updates
TomAugspurger Dec 19, 2019
d57b0ac
Revert "updates"
TomAugspurger Dec 19, 2019
36be0f6
examples
TomAugspurger Dec 20, 2019
7bd6c2f
restore datetime fix
TomAugspurger Dec 20, 2019
c5f3afb
Merge remote-tracking branch 'upstream/master' into na-indexing-raises
TomAugspurger Dec 20, 2019
76bb6ce
Merge branch 'master' of https://github.com/pandas-dev/pandas into na…
TomAugspurger Dec 28, 2019
505112e
update error message
TomAugspurger Dec 28, 2019
c73ae8e
checks
TomAugspurger Dec 28, 2019
3efe359
Merge remote-tracking branch 'upstream/master' into na-indexing-raises
TomAugspurger Dec 30, 2019
f94483f
update for error message
TomAugspurger Dec 30, 2019
953938d
Merge remote-tracking branch 'upstream/master' into na-indexing-raises
TomAugspurger Dec 30, 2019
8b1e567
update isort
TomAugspurger Dec 30, 2019
f317c64
isort
TomAugspurger Dec 30, 2019
c656292
fixup
TomAugspurger Dec 30, 2019
d4f0adc
Merge branch 'master' of https://github.com/pandas-dev/pandas into na…
TomAugspurger Dec 31, 2019
37ea95e
fixup
TomAugspurger Dec 31, 2019
816a47c
Merge remote-tracking branch 'upstream/master' into na-indexing-raises
TomAugspurger Jan 2, 2020
21fd589
update arrayo
TomAugspurger Jan 2, 2020
3637070
doc
TomAugspurger Jan 2, 2020
61599f2
integer
TomAugspurger Jan 2, 2020
6a0eda6
Merge remote-tracking branch 'upstream/master' into na-indexing-raises
TomAugspurger Jan 2, 2020
e622826
fixup
TomAugspurger Jan 2, 2020
5004d91
fixup
TomAugspurger Jan 2, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update error message
  • Loading branch information
TomAugspurger committed Dec 28, 2019
commit 505112eb3d3b45e3fd19b178022ff2e94537ed3d
2 changes: 1 addition & 1 deletion pandas/core/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def is_bool_indexer(key: Any) -> bool:
api.extensions.check_bool_array_indexer : Check that `key`
is a valid mask for an array, and convert to an ndarary.
"""
na_msg = "cannot index with vector containing NA / NaN values"
na_msg = "cannot mask with array containing NA / NaN values"
if isinstance(key, (ABCSeries, np.ndarray, ABCIndex)) or (
is_array_like(key) and is_extension_array_dtype(key.dtype)
):
Expand Down
4 changes: 2 additions & 2 deletions pandas/tests/extension/base/getitem.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def test_getitem_mask_raises(self, data):
with pytest.raises(IndexError):
data[mask]

def test_getitem_boolenarray_mask(self, data):
def test_getitem_boolean_array_mask(self, data):
mask = pd.array(np.zeros(data.shape, dtype="bool"), dtype="boolean")
result = data[mask]
assert len(result) == 0
Expand All @@ -149,7 +149,7 @@ def test_getitem_boolenarray_mask(self, data):
result = pd.Series(data)[mask]
self.assert_series_equal(result, expected)

def test_getitem_boolenarray_mask_raises(self, data):
def test_getitem_boolean_array_mask_raises(self, data):
mask = pd.array(np.zeros(data.shape, dtype="bool"), dtype="boolean")
mask[:2] = pd.NA
with pytest.raises(ValueError):
Expand Down
0