8000 ENH: add BooleanArray extension array by jorisvandenbossche · Pull Request #29555 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

ENH: add BooleanArray extension array #29555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Nov 25, 2019
Merged

ENH: add BooleanArray extension array #29555

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
640dac9
ENH: add BooleanArray extension array
jorisvandenbossche Nov 11, 2019
b9597bb
enable arithmetic ops + ufuncs
jorisvandenbossche Nov 12, 2019
fa77b7a
switch back to object dtype for __array__ + astype tests
jorisvandenbossche Nov 12, 2019
29415a9
temp
jorisvandenbossche Nov 12, 2019
c4a53f2
Merge remote-tracking branch 'upstream/master' into boolean-EA
jorisvandenbossche Nov 14, 2019
b1182bc
updates for feedback + add BooleanArray docstring
jorisvandenbossche Nov 15, 2019
94c5a90
Merge remote-tracking branch 'upstream/master' into boolean-EA
jorisvandenbossche Nov 18, 2019
1861602
try fix test for old numpy
jorisvandenbossche Nov 18, 2019
ad6c477
fix in place modification of mask / follow numpy for division
jorisvandenbossche Nov 18, 2019
67bf21a
string -> boolean copy paste errors
jorisvandenbossche Nov 18, 2019
f153fb2
add basic docs
jorisvandenbossche Nov 18, 2019
e24c097
empty test
jorisvandenbossche Nov 18, 2019
f0d0c6e
fix BooleanDtype construction + doc lint
jorisvandenbossche Nov 19, 2019
a3e1e93
Merge remote-tracking branch 'upstream/master' into boolean-EA
jorisvandenbossche Nov 20, 2019
1717583
add extra tests for constructors + check dimensionality
jorisvandenbossche Nov 20, 2019
5ce67e2
validate values when converting to boolean array
jorisvandenbossche Nov 20, 2019
8c0abe6
various updates
jorisvandenbossche Nov 20, 2019
031a113
fix + test return types of reducers
jorisvandenbossche Nov 20, 20 8000 19
90558d6
fix base reduction tests
jorisvandenbossche Nov 20, 2019
af82754
Merge remote-tracking branch 'upstream/master' into boolean-EA
jorisvandenbossche Nov 25, 2019
0eb3ca2
small edits
jorisvandenbossche Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
temp
  • Loading branch information
@jorisvandenbossche
jorisvandenbossche committed Nov 12, 2019
commit 29415a900b80ec45d124e2932d8cb67cd9c70e59
3 changes: 1 addition & 2 deletions pandas/core/arrays/boolean.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,8 +582,7 @@ def _reduce(self, name, skipna=True, **kwargs):
if name in ["any", "all"]:
pass

# if we have a preservable numeric op,
# provide coercion back to an integer type if possible
# if we have numeric op that would result in an int, coerce to int if possible
elif name in ["sum", "min", "max", "prod"] and notna(result):
int_result = int(result)
if int_result == result:
Expand Down
0