10000 Makes NumericIndex constructor dtype aware by oguzhanogreden · Pull Request #29529 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Makes NumericIndex constructor dtype aware #29529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 17, 2019
Merged

Makes NumericIndex constructor dtype aware #29529

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5bd9720
adds test case
oguzhanogreden Nov 10, 2019
5ad038f
Format file
oguzhanogreden Nov 10, 2019
d620c51
Fixes #29526
oguzhanogreden Nov 10, 2019
efc846d
Move tests
oguzhanogreden Nov 11, 2019
a59a945
Suggested improvements
oguzhanogreden Nov 11, 2019
5c7c65c
Does not rely on explicit arguments
oguzhanogreden Nov 11, 2019
9ab3596
Test directly, second pass
oguzhanogreden Nov 11, 2019
14e4e03
Adds what's new entry
oguzhanogreden Nov 11, 2019
68fe304
Remove tailing whitespace in whatsnew entry
oguzhanogreden Nov 14, 2019
458c25e
Move string check into Index._coerce_to_ndarray
oguzhanogreden Nov 14, 2019
1df13c0
Reverts 458c25e89 and 5c7c65c5e
oguzhanogreden Nov 16, 2019
e6d5f6b
Fix formatting
oguzhanogreden Nov 16, 2019
a51bcec
Fix formatting in test_numeric.py
oguzhanogreden Nov 16, 2019
13bda84
Moves _coerce_to_ndarray definition to NumericIndex
oguzhanogreden Nov 17, 2019
60b4f7b
Adds type hint for dtype and requires it
oguzhanogreden Nov 17, 2019
b41893d
Adds docstring
oguzhanogreden Nov 17, 2019
c9db704
Fixes typo in docstring
oguzhanogreden Nov 17, 2019
5603e0f
Remove coerce_to_ndarray, add to __new__
oguzhanogreden Nov 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adds type hint for dtype and requires it
  • Loading branch information
@oguzhanogreden
oguzhanogreden committed Nov 17, 2019
commit 60b4f7bfefaad7baac1e5e0ab86a14b701c30c3c
3 changes: 2 additions & 1 deletion pandas/core/indexes/numeric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from typing import Optional
import warnings

import numpy as np
Expand Down Expand Up @@ -130,7 +131,7 @@ def _assert_safe_casting(cls, data, subarr):
pass

@classmethod
def _coerce_to_ndarray(cls, data, dtype=None):
def _coerce_to_ndarray(cls, data, dtype: Optional[np.dtype]):
"""
Coerces data to ndarray.

Expand Down
0