8000 Inconsistent indexes for tick label plotting by nrebena · Pull Request #28733 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Inconsistent indexes for tick label plotting #28733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 21, 2020
Merged

Inconsistent indexes for tick label plotting #28733

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3699e11
TST: Test for issues #26186 and #11465
nrebena Oct 1, 2019
82a3110
BUG: Generate the tick position in BarPlot using convert tools from m…
nrebena Oct 1, 2019
c449d59
TST: Modify tests/plotting/test_frame.test_bar_categorical
nrebena Oct 1, 2019
a1d9a53
TST: Fix test for windows OS
nrebena Oct 1, 2019
383e7a4
TST: Add test for plotting MultiIndex bar plot
nrebena Oct 1, 2019
85881d1
BUG: Special case for MultiIndex bar plot
nrebena Oct 3, 2019
8661103
DOC: Add whatsnew entry for PR #28733
nrebena Oct 3, 2019
0ef2dd5
CLN: Clean up in code and doc
nrebena Oct 6, 2019
e22710a
CLN: Clean up test_bar_numeric
nrebena Nov 14, 2019
52cfacb
DOC Move to whatsnew v1.1
nrebena Feb 12, 2020
0ac15a0
FIX: Make tick dtype int for backwards compatibility
nrebena Feb 15, 2020
70683b8
DOC: Improve whatsnew message
nrebena Mar 15, 2020
3c8b54f
ENH: Add UserWarning when plotting bar plot with MultiIndex
nrebena Mar 15, 2020
28f06fc
CLN: Remove duplicate code line
nrebena Jun 13, 2020
c19ef4b
TST: Capture UserWarning for Bar plot with MultiIndex
nrebena Jun 13, 2020
a28db9c
TST: Improve test explanation
nrebena Jun 14, 2020
1e39ad9
ENH: Raise UserWarning only if redrawing on existing axis with data
nrebena Jun 14, 2020
23635d4
DOC: Move to whatsnew v1.2.9
nrebena Sep 12, 2020
9593256
Merge remote-tracking branch 'upstream/master' into pr/nrebena-issue_…
MarcoGorelli Nov 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
BUG: Generate the tick position in BarPlot using convert tools from m… 
…atlab.

Generate the tick position in BarPlot using convert tools from matlab.
  • Loading branch information
@nrebena
nrebena committed Sep 12, 2020
commit 82a3110613d233a34cf468c8c5ae297015e7c1dd
17 changes: 13 additions & 4 deletions pandas/plotting/_matplotlib/core.py
View file
Open in desktop
8000
Original file line number Diff line number Diff line change
Expand Up @@ -1333,7 +1333,6 @@ def __init__(self, data, **kwargs):
self.bar_width = kwargs.pop("width", 0.5)
pos = kwargs.pop("position", 0.5)
kwargs.setdefault("align", "center")
self.tick_pos = np.arange(len(data))

self.bottom = kwargs.pop("bottom", 0)
self.left = kwargs.pop("left", 0)
Expand All @@ -1356,7 +1355,7 @@ def __init__(self, data, **kwargs):
self.tickoffset = self.bar_width * pos
self.lim_offset = 0

self.ax_pos = self.tick_pos - self.tickoffset
self.ax_index = self.data.index

def _args_adjust(self):
if is_list_like(self.bottom):
Expand All @@ -1383,6 +1382,16 @@ def _make_plot(self):

for i, (label, y) in enumerate(self._iter_data(fillna=0)):
ax = self._get_ax(i)

if self.orientation == 'vertical':
ax.xaxis.update_units(self.ax_index)
self.tick_pos = ax.convert_xunits(self.ax_index)
self.ax_pos = self.tick_pos - self.tickoffset
elif self.orientation == 'horizontal':
ax.yaxis.update_units(self.ax_index)
self.tick_pos = ax.convert_yunits(self.ax_index)
self.ax_pos = self.tick_pos - self.tickoffset
Copy link
Member
@charlesdong1991 charlesdong1991 May 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this self.ax_pos = self.tick_pos - self.tickoffset can be taken out from if.. else.. clause, and no need to use it twice. the main purpose of this clause is to get self.tick_pos for bar and barh separately.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing.


kwds = self.kwds.copy()
if self._is_series:
kwds["color"] = colors
Expand Down Expand Up @@ -1454,8 +1463,8 @@ def _post_plot_logic(self, ax: "Axes", data):
str_index = [pprint_thing(key) for key in range(data.shape[0])]
name = self._get_index_name()

s_edge = self.ax_pos[0] - 0.25 + self.lim_offset
e_edge = self.ax_pos[-1] + 0.25 + self.bar_width + self.lim_offset
s_edge = self.ax_pos.min() - 0.25 + self.lim_offset
e_edge = self.ax_pos.max() + 0.25 + self.bar_width + self.lim_offset

self._decorate_ticks(ax, name, str_index, s_edge, e_edge)

Expand Down
0