8000 CLN: Remove unused vars in roll_window by ihsansecer · Pull Request #27294 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

CLN: Remove unused vars in roll_window #27294

New issue < 8000 button aria-label="Close dialog" data-close-dialog="" type="button" data-view-component="true" class="Link--muted btn-link position-absolute p-4 right-0">

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2019
Merged

CLN: Remove unused vars in roll_window #27294

merged 1 commit into from
Jul 9, 2019

Conversation

ihsansecer
Copy link
Contributor

No description provided.

@WillAyd WillAyd added Clean Window rolling, ewma, expanding labels Jul 8, 2019
@WillAyd
Copy link
Member
WillAyd commented Jul 8, 2019

lgtm - nice catch! Is there any way to auto-detect this in Cython? Vaguely recall trying but there being some linting limitation @jbrockmendel

@jbrockmendel
Copy link
Member

We're not going to get flake8 working on the cython files anytime soon, so maybe we can get gcc/clang/whatever to issue a warning about declared-but-unused variables?

@jreback jreback added this to the 0.25.0 milestone Jul 9, 2019
@jreback jreback merged commit e94639b into pandas-dev:master Jul 9, 2019
@jreback
Copy link
Contributor
jreback commented Jul 9, 2019

thanks @ihsansecer

@ihsansecer ihsansecer deleted the win-unused-var branch July 11, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@ruidazeng ruidazeng ruidazeng approved these changes

Assignees
No one assigned
Labels
Clean Window rolling, ewma, expanding
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ihsansecer @WillAyd @jbrockmendel @jreback @ruidazeng
0