Remove imag/real

pandas-dev · jreback · Jun 28, 2019 · Jun 28, 2019 · Jun 28, 2019 · Jun 28, 2019
commit b9f21f3a380e77de359a1131dc659aa6d16a42a2
diff --git a/doc/source/whatsnew/v0.25.0.rst b/doc/source/whatsnew/v0.25.0.rst
@@ -605,7 +605,7 @@ Other deprecations
   Instead, use :meth:`Series.dtype` and :meth:`DataFrame.dtypes` (:issue:`26705`).
 - :meth:`Timedelta.resolution` is deprecated and replaced with :meth:`Timedelta.resolution_string`.  In a future version, :meth:`Timedelta.resolution` will be changed to behave like the standard library :attr:`timedelta.resolution` (:issue:`21344`)
 - :attr:`Index.dtype_str` is deprecated. (:issue:``)
-- 
+-
 
 .. _whatsnew_0250.prior_deprecations:
 

diff --git a/pandas/core/nanops.py b/pandas/core/nanops.py
@@ -1275,7 +1275,7 @@ def _ensure_numeric(x):
             except (TypeError, ValueError):
                 x = x.astype(np.float64)
             else:
-                if not np.any(x.imag):
+                if not np.any(np.imag(x)):
                     x = x.real
     elif not (is_float(x) or is_integer(x) or is_complex(x)):
         try:

diff --git a/pandas/core/series.py b/pandas/core/series.py
@@ -793,7 +793,11 @@ def __array_prepare__(self, result, context=None):
     def real(self):
         """
         Return the real value of vector.
+
+        .. deprecated 0.25.0
         """
+        warnings.warn("`real` has be deprecated and will be removed in a "
+                      "future verison", DeprecationWarning, stacklevel=2)
         return self.values.real
 
     @real.setter
@@ -804,7 +808,11 @@ def real(self, v):
     def imag(self):
         """
         Return imag value of vector.
+
+        .. deprecated 0.25.0
         """
+        warnings.warn("`imag` has be deprecated and will be removed in a "
+                      "future verison", DeprecationWarning, stacklevel=2)
         return self.values.imag
 
     @imag.setter

diff --git a/pandas/core/util/hashing.py b/pandas/core/util/hashing.py
@@ -269,7 +269,7 @@ def hash_array(vals, encoding='utf8', hash_key=None, categorize=True):
     # we'll be working with everything as 64-bit values, so handle this
     # 128-bit value early
     if np.issubdtype(dtype, np.complex128):
-        return hash_array(vals.real) + 23 * hash_array(vals.imag)
+        return hash_array(np.real(vals)) + 23 * hash_array(np.imag(vals))
 
     # First, turn whatever array this is into unsigned 64-bit ints, if we can
     # manage it.

diff --git a/pandas/io/packers.py b/pandas/io/packers.py
@@ -523,16 +523,16 @@ def encode(obj):
             return {'typ': 'np_scalar',
                     'sub_typ': 'np_complex',
                     'dtype': obj.dtype.name,
-                    'real': obj.real.__repr__(),
-                    'imag': obj.imag.__repr__()}
+                    'real': np.real(obj).__repr__(),
+                    'imag': np.imag(obj).__repr__()}
         else:
             return {'typ': 'np_scalar',
                     'dtype': obj.dtype.name,
                     'data': obj.__repr__()}
     elif isinstance(obj, complex):
         return {'typ': 'np_complex',
-                'real': obj.real.__repr__(),
-                'imag': obj.imag.__repr__()}
+                'real': np.real(obj).__repr__(),
+                'imag': np.imag(obj).__repr__()}
 
     return obj
 

diff --git a/pandas/tests/series/test_dtypes.py b/pandas/tests/series/test_dtypes.py
@@ -433,12 +433,18 @@ def test_complex(self):
         a = np.arange(5, dtype=np.float64)
         b = Series(a + 4j * a)
 
-        tm.assert_numpy_array_equal(a, b.real)
-        tm.assert_numpy_array_equal(4 * a, b.imag)
+        tm.assert_numpy_array_equal(a, np.real(b))
+        tm.assert_numpy_array_equal(4 * a, np.imag(b))
 
         b.real = np.arange(5) + 5
-        tm.assert_numpy_array_equal(a + 5, b.real)
-        tm.assert_numpy_array_equal(4 * a, b.imag)
+        tm.assert_numpy_array_equal(a + 5, np.real(b))
+        tm.assert_numpy_array_equal(4 * a, np.imag(b))
+
+    def test_real_imag_deprecated(self):
+        s = pd.Series([1])
+        with tm.assert_produces_warning(DeprecationWarning):
+            s.imag
+            s.real
 
     def test_arg_for_errors_in_astype(self):
         # see gh-14878

diff --git a/pandas/tests/test_nanops.py b/pandas/tests/test_nanops.py
@@ -144,9 +144,9 @@ def _coerce_tds(targ, res):
             # but nanops doesn't, so make that an exception
             elif targ.dtype.kind == 'O':
                 raise
-            tm.assert_almost_equal(targ.real, res.real,
+            tm.assert_almost_equal(np.real(targ), np.real(res),
                                    check_dtype=check_dtype)
-            tm.assert_almost_equal(targ.imag, res.imag,
+            tm.assert_almost_equal(np.imag(targ), np.imag(res),
                                    check_dtype=check_dtype)
 
     def check_fun_data(self, testfunc, targfunc, testarval, targarval,