8000 Fix type annotations in pandas.core.indexes.datetimes by vaibhavhrt · Pull Request #26404 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

Fix type annotations in pandas.core.indexes.datetimes #26404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 24, 2019
Merged

Fix type annotations in pandas.core.indexes.datetimes #26404

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
4933ba8
fis type annotation
vaibhavhrt May 13, 2019
64ded46
Merge remote-tracking branch 'upstream/master'
vaibhavhrt May 13, 2019
fcfb6ef
Merge remote-tracking branch 'upstream/master'
vaibhavhrt May 15, 2019
cb3c875
fix some errors and remove the module from mypy.ini
vaibhavhrt May 15, 2019
ca7e8eb
fix linting errors
vaibhavhrt May 15, 2019
fd3f277
Merge remote-tracking branch 'upstream/master'
vaibhavhrt May 17, 2019
e82720d
Merge branch 'master' into pandas.core.indexes.datetimes
vaibhavhrt May 17, 2019
10f1c4d
fix import sorting errors
vaibhavhrt May 17, 2019
247dd31
fix the function signature of map to be consistent across different c…
vaibhavhrt May 20, 2019
9bfd9f2
don't specify type of _data to make it's type consistent across classes
vaibhavhrt May 20, 2019
4680fd4
fix signature of function _format_with_header to be consistent across…
vaibhavhrt May 20, 2019
e59dc6a
fix signature of function isin to be consistent acoross classes
vaibhavhrt May 20, 2019
e455bb0
Merge branch 'master' into pandas.core.indexes.datetimes
vaibhavhrt May 20, 2019
078d490
remove pandas.core.indexes.timedeltas from mypy.ini too as all its is…
8000 vaibhavhrt May 20, 2019
c4a17b5
fix tests (hopefully)
vaibhavhrt May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix some errors and remove the module from mypy.ini
  • Loading branch information
@vaibhavhrt
vaibhavhrt committed May 15, 2019
commit cb3c8753377372e6421da1a7116df03a26533d63
3 changes: 0 additions & 3 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ ignore_errors=True
[mypy-pandas.core.indexes.datetimelike]
ignore_errors=True

[mypy-pandas.core.indexes.datetimes]
ignore_errors=True

[mypy-pandas.core.indexes.period]
ignore_errors=True

Expand Down
9 changes: 5 additions & 4 deletions pandas/core/indexes/datetimes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
import numpy as np

from pandas._libs import (
Timestamp, index as libindex, join as libjoin, lib, tslib as libts)
Timestamp, index as libindex, lib, tslib as libts)
import pandas._libs.join as libjoin
from pandas._libs.tslibs import ccalendar, fields, parsing, timezones
from pandas.util._decorators import Appender, Substitution, cache_readonly

Expand Down Expand Up @@ -1112,9 +1113,9 @@ def slice_indexer(self, st 5ED4 art=None, end=None, step=None, kind=None):
_is_monotonic_decreasing = Index.is_monotonic_decreasing
_is_unique = Index.is_unique

_timezone = cache_readonly(DatetimeArray._timezone.fget)
is_normalized = cache_readonly(DatetimeArray.is_normalized.fget)
_resolution = cache_readonly(DatetimeArray._resolution.fget)
_timezone = cache_readonly(DatetimeArray._timezone.fget) # type: ignore
is_normalized = cache_readonly(DatetimeArray.is_normalized.fget) # type: ignore
_resolution = cache_readonly(DatetimeArray._resolution.fget) # type: ignore

strftime = ea_passthrough(DatetimeArray.strftime)
_has_same_tz = ea_passthrough(DatetimeArray._has_same_tz)
Expand Down
0