Whatsnew, second rev indexing, window and pytables

pandas-dev · WillAyd · May 18, 2019 · May 7, 2019 · May 8, 2019 · May 9, 2019
commit 2eeff8cb9eee425e8dfb195944bdbd137b5b2b9c
diff --git a/doc/source/whatsnew/v0.25.0.rst b/doc/source/whatsnew/v0.25.0.rst
@@ -217,6 +217,7 @@ Other API Changes
 - Comparing :class:`Timestamp` with unsupported objects now returns :py:obj:`NotImplemented` instead of raising ``TypeError``. This implies that unsupported rich comparisons are delegated to the other object, and are now consistent with Python 3 behavior for ``datetime`` objects (:issue:`24011`)
 - Bug in :meth:`DatetimeIndex.snap` which didn't preserving the ``name`` of the input :class:`Index` (:issue:`25575`)
 - The ``arg`` argument in :meth:`pandas.core.groupby.DataFrameGroupBy.agg` has been renamed to ``func`` (:issue:`26089`)
+- The ``arg`` argument in :meth:`pandas.core.window._Window.aggregate` has been renamed to ``func`` (:issue:`26372`)
 
 .. _whatsnew_0250.deprecations:
 

diff --git a/pandas/core/indexing.py b/pandas/core/indexing.py
@@ -1,5 +1,4 @@
 import textwrap
-from typing import Type
 import warnings
 
 import numpy as np
@@ -90,7 +89,7 @@ class IndexingError(Exception):
 
 class _NDFrameIndexer(_NDFrameIndexerBase):
     _valid_types = None  # type: str
-    _exception = KeyError  # type: Type[Exception]
+    _exception = Exception
     axis = None
 
     def __call__(self, axis=None):

diff --git a/pandas/core/window.py b/pandas/core/window.py
@@ -5,7 +5,7 @@
 from collections import defaultdict
 from datetime import timedelta
 from textwrap import dedent
-from typing import Set, no_type_check
+from typing import Set
 import warnings
 
 import numpy as np
@@ -789,11 +789,7 @@ def __init__(self, obj, *args, **kwargs):
     corr = GroupByMixin._dispatch('corr', other=None, pairwise=None)
     cov = GroupByMixin._dispatch('cov', other=None, pairwise=None)
 
-    # Removed from type checking because there is currently no good way to
-    # handle multiple inheritance with mypy
-    # https://github.com/python/mypy/issues/2125
-    @no_type_check
-    def _apply(self, func, name, window=None, center=None,
+    def _apply(self, func, name=None, window=None, center=None,
                check_minp=None, **kwargs):
         """
         Dispatch to apply; we are stripping all of the _apply kwargs and

diff --git a/pandas/io/pytables.py b/pandas/io/pytables.py
@@ -3053,7 +3053,7 @@ class Table(Fixed):
 
         """
     pandas_kind = 'wide_table'
-    table_type = None  # type: Optional[str]
+    table_type = None  # type: str
     levels = 1
     is_table = True
     is_shape_reversed = False