CLN: Remove redundant definitions in pandas.compat (filter, map, range, etc.) #25845

jschendel · 2019-03-23T04:36:02Z

jschendel · 2019-03-23T04:40:21Z

pandas/tests/test_compat.py

-            assert iter_res == exp
-            assert list_res == exp
-
-    def test_range(self):


This is pretty much the only non-trivial change - edited some tests that would now just be testing the builtin range/map/filter/zip functions. Updated to just test the list equivalent functions, and slightly changed some variable names to better match other test conventions.

codecov · 2019-03-23T05:14:50Z

codecov · 2019-03-23T05:14:50Z

jreback · 2019-03-23T20:13:36Z

CLN: Remove redundant definitions in pandas.compat (filter, map, rang…

8c3c1b2

…e, etc.)

jschendel added 2/3 Compat Clean labels Mar 23, 2019

jschendel added this to the 0.25.0 milestone Mar 23, 2019

jschendel commented Mar 23, 2019

View reviewed changes

Also remove ResourceWarning

583841b

jreback merged commit 6e0f9a9 into pandas-dev:master Mar 23, 2019

jschendel deleted the remove-compat-redundant branch March 23, 2019 20:14

tswast mentioned this pull request Apr 3, 2019

TST: Update Conda CI build to use nightly pandas packages. googleapis/python-bigquery-pandas#254

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

CLN: Remove redundant definitions in pandas.compat (filter, map, range, etc.) #25845

CLN: Remove redundant definitions in pandas.compat (filter, map, range, etc.) #25845

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CLN: Remove redundant definitions in pandas.compat (filter, map, range, etc.) #25845

CLN: Remove redundant definitions in pandas.compat (filter, map, range, etc.) #25845

Uh oh!

Conversation

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Codecov Report

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!