8000 #25790 Updating type hints to Python3 syntax in pandas/core/array by gwrome · Pull Request #25829 · pandas-dev/pandas · GitHub
[go: up one dir, main page]

Skip to content

#25790 Updating type hints to Python3 syntax in pandas/core/array #25829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 30, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleaned up array/ type hints
  • Loading branch information
gwrome committed Mar 22, 2019
commit abc09faf7d349d2e5b977d374909e6359fde06d5
2 changes: 1 addition & 1 deletion pandas/core/arrays/array_.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@


def array(data: Sequence[object],
dtype: Optional[Union[str, np.dtype, ExtensionDtype]] = None,
dtype: Optional[str, np.dtype, ExtensionDtype] = None,
copy: bool = True,
) -> ExtensionArray:
"""
Expand Down
2 changes: 1 addition & 1 deletion pandas/core/arrays/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ def take(
self,
indices: Sequence[int],
allow_fill: bool = False,
fill_value: Optional[Any] = None
fill_value: Any = None
) -> 'ExtensionArray':
"""
Take elements from an array.
Expand Down
3 changes: 2 additions & 1 deletion pandas/core/arrays/sparse.py
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,8 @@ def _get_fill(arr: 'SparseArray') -> np.ndarray:
def _sparse_array_op(
left: 'SparseArray',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ABCSparseArray

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're good to go @WillAyd @jreback

right: 'SparseArray',
op: Callable, name: str
op: Callable,
name: str
) -> Any:
"""
Perform a binary operation between two arrays.
Expand Down
0