8000 BUG: Fix bug when using df.query with "str.contains()" by dtpc · Pull Request #25813 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: Fix bug when using df.query with "str.contains()" #25813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

BUG: Fix bug when using df.query with "str.contains()" #25813

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8f22ebc
TST: Test df.query with "str.contains()"
dtpc Mar 20, 2019
64004bc
BUG: Fix bug when using eval to call "str" methods
dtpc Mar 20, 2019
087157c
DOC: Update whatsnew v0.25.0 for named kwarg `eval` fix (#25813)
dtpc Mar 21, 2019
36b0f43
DOC: Remove trailing whitespace
dtpc Mar 21, 2019
63122dc
Merge remote-tracking branch 'pandas/master' into fix/eval_str_contains
dtpc Apr 13, 2019
223e034
TST: Test explicitly pd.eval with named keyword argument (#25813)
dtpc Apr 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
BUG: Fix bug when using eval to call "str" methods
  • Loading branch information
@dtpc
dtpc committed Mar 21, 2019
commit 64004bc139acf82009d68a508cf0961397b868cb
5 changes: 1 addition & 4 deletions pandas/core/computation/expr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,11 +632,8 @@ def visit_Call_35(self, node, side=None, **kwargs):
if not isinstance(key, ast.keyword):
raise ValueError("keyword error in function call "
"'{func}'".format(func=node.func.id))

if key.arg:
# TODO: bug?
kwargs.append(ast.keyword(
keyword.arg, self.visit(keyword.value))) # noqa
kwargs[key.arg] = self.visit(key.value)()

return self.const_type(res(*new_args, **kwargs), self.env)

Expand Down
0