-
-
Notifications
You must be signed in to change notification settings - Fork 18.7k
PR04 errors fix #25157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
PR04 errors fix #25157
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
0dc07f2
Partial PR04 errors fix
mwoss b93e438
Fix rest of the R04 errors
mwoss ae369ec
PEP8 - line too long fix
mwoss 3ac2383
Add additional space between param name and type, add new lines to
mwoss 7651a63
Add PR04 errors check to code_check script
mwoss 93654b9
Merge branch 'master' into issue-25105
mwoss ce46f24
Additional docs fixes related to PR04 errors
mwoss e9fdd08
Merge remote-tracking branch 'origin/issue-25105' into issue-25105
mwoss 63aaaf0
Remove unnecessary colons and note section in Grouper docs
mwoss 0447294
Merge branch 'master' into issue-25105
mwoss aeed6ab
Change parameter order
mwoss 9308491
Merge remote-tracking branch 'origin/issue-25105' into issue-25105
mwoss 4bb3b0b
Remove encoding param in opening named temp file
mwoss f95c4b5
Merge branch 'master' into issue-25105
mwoss 619253c
Separate types and descriptions
mwoss 8113c21
Merge remote-tracking branch 'origin/issue-25105' into issue-25105
mwoss bffd111
Remove errant colon
WillAyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove unnecessary colons and note section in Grouper docs
- Loading branch information
commit 63aaaf0b5ee83a0b60c241942df55ce9aa18c57a
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -543,7 +543,7 @@ def validate_pep8(self): | |
application = flake8.main.application.Application() | ||
application.initialize(["--quiet"]) | ||
|
||
with tempfile.NamedTemporaryFile(mode='w') as file: | ||
with tempfile.NamedTemporaryFile(mode='w', encoding='utf-8') as file: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you can revert this I think the rest looks good There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh, i again commit this line. I should create github issue with coresponding PR for that. |
||
file.write(content) | ||
file.flush() | ||
application.run_checks([file.name]) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry just one last pass at all of these where
Only when freq...
is the description - not sure that's the best way of going about this.It looks like the description for these is where the type should go. Can you move the description down to the line below and add a type for this and the 3 other parameters sharing this description? Also would be nice to revert removal of previous line if it doesn't cause PR04 failures
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean by sharing the description? Should I group those kwargs somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll fix it in few hours. Sorry, busy weekend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how deal with line below (for all kwargs).
There is no description sharing functionality for Python docstrings.