8000 BUG: avoid usage in_qtconsole for recent IPython versions by TomAugspurger · Pull Request #25039 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

BUG: avoid usage in_qtconsole for recent IPython versions #25039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 31, 2019
Merged

BUG: avoid usage in_qtconsole for recent IPython versions #25039

merged 5 commits into from
Jan 31, 2019

Conversation

TomAugspurger
Copy link
Contributor
@TomAugspurger TomAugspurger commented Jan 30, 2019 •
edited
Loading

I've verified this manually with qtconsole 4.4.0, but if others want to check that'd be helpful.

screen shot 2019-01-30 at 2 22 06 pm

What release should this be done in? 0.24.1, 0.24.2 or 0.25.0?

Closes #25036

@TomAugspurger
Copy link
Contributor Author

For reference, IPython 3.0 was released in Feb. 2015 https://pypi.org/project/ipython/3.0.0/

@codecov
Copy link
codecov bot commented Jan 30, 2019 •
edited
Loading

Codecov Report

Merging #25039 into master will decrease coverage by <.01%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25039      +/-   ##
==========================================
- Coverage   92.37%   92.37%   -0.01%     
==========================================
  Files         166      166              
  Lines       52397    52403       +6     
==========================================
+ Hits        48404    48405       +1     
- Misses       3993     3998       +5
Flag Coverage Δ
#multiple 90.79% <62.5%> (-0.02%) ⬇️
#single 42.87% <12.5%> (-0.01%) ⬇️
Impacted Files Coverage Δ
pandas/core/frame.py 96.82% <62.5%> (-0.11%) ⬇️
pandas/io/formats/console.py 66.66% <0%> (-5.8%) ⬇️
pandas/util/testing.py 88.13% <0%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149138e...acd50bb. Read the comment docs.

@jorisvandenbossche
Copy link
Member

What release should this be done in? 0.24.1, 0.24.2 or 0.25.0?

Is there a reason to already do it in 0.24.x ?

@jreback
Copy link
Contributor
jreback commented Jan 30, 2019

sure we should drop, but this should be done in 0.25

@jreback jreback added the Dependencies Required and optional dependencies label Jan 30, 2019
@TomAugspurger
Copy link
Contributor Author

The reason to do it soon is because it's affecting users: #25036 I see that I forgot to link to that in the PR, sorry.

@jorisvandenbossche
Copy link
Member
jorisvandenbossche commented Jan 30, 2019 •
edited
Loading

I suppose #25036 is the reason?

As a solution for 0.24.1, we could also check the version of IPython, and only run that code for old IPython versions. So we don't break support in a bug fix release, but we also actually fix the bug for most users that will not have such old IPython version.

@jreback
Copy link
Contributor
jreback commented Jan 30, 2019

ok this seems fine then for 0.24.1

@jreback jreback added this to the 0.24.1 milestone Jan 30, 2019
@jreback
Copy link
Contributor
jreback commented Jan 30, 2019

can you add a note in whatsnew

@TomAugspurger
Copy link
Contributor Author

@jorisvandenbossche switched to the check you suggested in
#25039 (comment), if you want to check.

I'll followup with the original PR of removing all this shortly after 0.24.1.

jorisvandenbossche
jorisvandenbossche approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member
@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jorisvandenbossche jorisvandenbossche changed the title Drop IPython<3.0 compat BUG: avoid usage in_qtconsole for recent IPython versions Jan 31, 2019
@jorisvandenbossche jorisvandenbossche merged commit da5f5eb into pandas-dev:master Jan 31, 2019
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 31, 2019
@TomAugspurger
Backport PR pandas-dev#25039: BUG: avoid usage in_qtconsole for recen…
b5895ed 
…t IPython versions
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 31, 2019
Merged
TomAugspurger pushed a commit that referenced this pull request Jan 31, 2019
@meeseeksmachine @TomAugspurger
Backport PR #25039: BUG: avoid usage in_qtconsole for recent IPython …
e3634b1 
…versions (#25054)
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
BUG: avoid usage in_qtconsole for recent IPython versions (pandas-dev…
3b7d98f 
…#25039)

* Drop IPython<4.0 compat

* Revert "Drop IPython<4.0 compat"

This reverts commit 0cb0452.

* update
a
* whatsnew
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@TomAugspurger @Pingviinituutti
BUG: avoid usage in_qtconsole for recent IPython versions (pandas-dev…
474d29d 
…#25039)

* Drop IPython<4.0 compat

* Revert "Drop IPython<4.0 compat"

This reverts commit 0cb0452.

* update
a
* whatsnew
the-nose-knows added a commit to the-nose-knows/pandas that referenced this pull request Mar 9, 2019
@the-nose-knows
upstream sync (#1)