8000 ENH: Quoting column names containing spaces with backticks to use them in query and eval. by hwalinga · Pull Request #24955 · pandas-dev/pandas · GitHub
[go: up one dir, main page]
Skip to content

ENH: Quoting column names containing spaces with backticks to use them in query and eval. #24955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 20, 2019
Merged

ENH: Quoting column names containing spaces with backticks to use them in query and eval. #24955

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ff463ca
TST: Add tests for backtick quoting (#6508)
hwalinga Jan 26, 2019
db9c769
Update docstring query about quoting backtick variables
hwalinga Jan 26, 2019
22686fd
Fixed whatsnew entry
hwalinga Feb 15, 2019
bfebb9d
Backtick quotes are now tokenized. More tests and pytest fixtures
hwalinga Feb 15, 2019
a65f5a5
Use compat.map; No import alias (operator) to prevent name shadowing
hwalinga Feb 16, 2019
da60955
Fix import order; Remove debug print;
hwalinga Feb 16, 2019
2125068
Add 'versionadded' and move column resolvers logic to common.py.
hwalinga Feb 24, 2019
5200b0c
Solve merge conflict whatsnew doc.
hwalinga Feb 24, 2019
63c25bf
More clarity in comments; Moved column resolver to class; Use uuid
hwalinga Mar 10, 2019
b104766
Merge conflict
hwalinga Mar 10, 2019
e496671
uuid3 python2/3 compatible function added
hwalinga Mar 10, 2019
d3877d1
Reverted uuid3
hwalinga Mar 10, 2019
bb62d73
Local import for computation.common; Added example in query
hwalinga Mar 10, 2019
192c093
Solve merge conflict whatsnew doc.
hwalinga Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
TST: Add tests for backtick quoting (#6508)
  • Loading branch information
@hwalinga
hwalinga committed Feb 15, 2019
commit ff463cac5a17c7518c12e68e24fa4e6ff4d1383b
31 changes: 31 additions & 0 deletions pandas/tests/frame/test_query_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1030,3 +1030,34 @@ def test_invalid_type_for_operator_raises(self, parser, engine, op):

with pytest.raises(TypeError, match=msg):
df.eval('a {0} b'.format(op), engine=engine, parser=parser)


class TestDataFrameQueryBacktickQuoting(object):

def setup_method(self, method):
self.df = DataFrame({'A': [1, 2, 3],
'B B': [3, 2, 1],
'C C': [4, 5, 6]})

def teardown_method(self, method):
del self.df

def test_single_backtick_variable_query(self):
res = self.df.query('1 < `B B`')
expect = self.df[1 < self.df['B B']]
assert_frame_equal(res, expect)

def test_two_backtick_variables_query(self):
res = self.df.query('1 < `B B` and 4 < `C C`')
expect = self.df[(1 < self.df['B B']) & (4 < self.df['C C'])]
assert_frame_equal(res, expect)

def test_single_backtick_variable_expr(self):
res = self.df.eval('A + `B B`')
expect = self.df['A'] + self.df['B B']
assert_series_equal(res, expect)

def test_two_backtick_variables_expr(self):
res = self.df.eval('`B B` + `C C`')
expect = self.df['B B'] + self.df['C C']
assert_series_equal(res, expect)
0