Test separated into own test. Added issue comment. Updated df var nam…

…es so more explicit in tm assertion call.
pandas-dev · jreback · Apr 26, 2019 · Jan 26, 2019 · Jan 26, 2019 · Jan 26, 2019
commit 416e9c85cc8ff676fed92f1760cc9de0158a40d9
diff --git a/pandas/tests/reshape/test_pivot.py b/pandas/tests/reshape/test_pivot.py
@@ -65,22 +65,24 @@ def test_pivot_table(self, observed):
             index + [columns])['D'].agg(np.mean).unstack()
         tm.assert_frame_equal(table, expected)
 
+    def test_pivot_table_categorical_observed(self, observed):
+        # issue #24923
         df = pd.DataFrame({'col1': list('abcde'),
                            'col2': list('fghij'),
                            'col3': [1, 2, 3, 4, 5]})
 
         df.col1 = df.col1.astype('category')
         df.col2 = df.col1.astype('category')
 
-        df_pivot = df.pivot_table(index='col1', values='col3',
+        expected = df.pivot_table(index='col1', values='col3',
                                   columns='col2', aggfunc=np.sum,
                                   fill_value=0)
 
-        df_pivot_observed = df.pivot_table(index='col1', values='col3',
-                                           columns='col2', aggfunc=np.sum,
-                                           fill_value=0, observed=observed)
+        result = df.pivot_table(index='col1', values='col3',
+                                columns='col2', aggfunc=np.sum,
+                                fill_value=0, observed=observed)
 
-        tm.assert_frame_equal(df_pivot, df_pivot_observed)
+        tm.assert_frame_equal(result, expected)
 
     def test_pivot_table_nocols(self):
         df = DataFrame({'rows': ['a', 'b', 'c'],